Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1207553002: Another attempt at fixing incorrect libxml fprintf, affecting clang win x64 (Closed)

Created:
5 years, 6 months ago by scottmg
Modified:
5 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@update-libxml-gyp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Another attempt at fixing incorrect libxml fprintf, affecting clang win x64 Previous attempt https://codereview.chromium.org/1204813002. R=thakis@chromium.org BUG=https://bugzilla.gnome.org/show_bug.cgi?id=751410 BUG=82385 Committed: https://crrev.com/d31995076e55f1aac2f935c53b585a90ece27a11 Cr-Commit-Position: refs/heads/master@{#335844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/libxml/src/timsort.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
scottmg
This seems simpler than fighting with everyone's special macros. I'll revert and land whatever upstream ...
5 years, 6 months ago (2015-06-23 21:26:15 UTC) #1
Nico
lgtm, but I think %llu requires msvs2005 or something like that on Windows (fine for ...
5 years, 6 months ago (2015-06-23 21:37:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207553002/1
5 years, 6 months ago (2015-06-24 00:21:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 01:25:35 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 01:28:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d31995076e55f1aac2f935c53b585a90ece27a11
Cr-Commit-Position: refs/heads/master@{#335844}

Powered by Google App Engine
This is Rietveld 408576698