Issue 1207543003: PNaCl: Add two new passes: `-rewrite-aggregate-arguments && `-rewrite-aggregate-returns`.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1207543003: PNaCl: Add two new passes: `-rewrite-aggregate-arguments && `-rewrite-aggregate-returns`. (Closed)

Created:
5 years, 6 months ago by Richard Diamond

Modified:
5 years, 6 months ago

Reviewers:
JF

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

PNaCl: Add two new passes: `-rewrite-aggregate-arguments && `-rewrite-aggregate-returns`. These two passes handle IR emitted by Rust by rewriting functions with aggregates in their signatures into a form `ExpandStructRegs` can successfully transform. R= jfb@chromium.org TEST= Run the in-tree LLVM tests. BUG=

Patch Set 1 #

Patch Set 2 : Fix and add a test. #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+536 lines, -0 lines)			Patch
M	include/llvm/InitializePasses.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/llvm/Transforms/NaCl.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/Transforms/NaCl/CMakeLists.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/Transforms/NaCl/PNaClABISimplify.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	lib/Transforms/NaCl/RewriteAggFuns.cpp	View		1 chunk	+389 lines, -0 lines	0 comments	Download
A	test/Transforms/NaCl/rewrite-agg-arg.ll	View		1 chunk	+82 lines, -0 lines	0 comments	Download
A	test/Transforms/NaCl/rewrite-agg-ret.ll	View	1	1 chunk	+51 lines, -0 lines	0 comments	Download
M	tools/bugpoint/bugpoint.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/opt/opt.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

This seems pretty similar to mtrofin's work in the following patch: https://codereview.chromium.org/992493002/ Doesn't his pass ...

5 years, 6 months ago (2015-06-24 23:54:55 UTC) #2

Richard Diamond

5 years, 6 months ago (2015-06-26 00:48:44 UTC) #3

On 2015/06/24 at 23:54:55, jfb wrote:
> This seems pretty similar to mtrofin's work in the following patch:
>   https://codereview.chromium.org/992493002/
> 
> Doesn't his pass handle some of the cases you care about?

Ah yes. Closing.

Expand Messages | Collapse Messages