Add inbox_app to silk page set

Add inbox_app to silk page set

This CL adds an app-style widget called app-drawer to the Silk page set. The
app-drawer widget comes from https://github.com/abarth/app-widgets and is based
on Android's navigation drawer:

http://developer.android.com/design/patterns/navigation-drawer.html

R=nduca@chromium.org
TBR=boliu@chromium.org
BUG=332439
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243722

[nduca, 2014-01-07 20:21:53]

lgtm for me, but lets get dominkg as well

https://codereview.chromium.org/120753003/diff/1/tools/perf/page_sets/key_sil...
File tools/perf/page_sets/key_silk_cases.json (right):

https://codereview.chromium.org/120753003/diff/1/tools/perf/page_sets/key_sil...
tools/perf/page_sets/key_silk_cases.json:131: { "action": "wait", "seconds": 2 }
is this wait us waiting for an animation to finish?

if so, i think you need to use wait_after feature of
https://codereview.chromium.org/117283004/ here so that telemetry sees the
slide_drawer action as the thing being measured.

[abarth-chromium, 2014-01-07 20:26:27]

https://codereview.chromium.org/120753003/diff/1/tools/perf/page_sets/key_sil...
File tools/perf/page_sets/key_silk_cases.json (right):

https://codereview.chromium.org/120753003/diff/1/tools/perf/page_sets/key_sil...
tools/perf/page_sets/key_silk_cases.json:131: { "action": "wait", "seconds": 2 }
On 2014/01/07 20:21:53, nduca wrote:
> is this wait us waiting for an animation to finish?

Yes.  Without this, telemetry complained that we were only measuring 2 frames

> if so, i think you need to use wait_after feature of
> https://codereview.chromium.org/117283004/ here so that telemetry sees the
> slide_drawer action as the thing being measured.

Makes sense.  Should I wait for that CL to land, or should I iterate on this
action after landing this CL?  For context, I expect to iterate on
app-drawer.html in the future.  I'm mostly interested in getting an end-to-end
example working so that Ojan and I can scale it up.

Related question: I'm surprised there isn't a "duration" or "speed" attribute
for swipe.  I was expecting to be able to control how quickly gesture proceeded.
 For example, a fast gesture results in a "fling" animation and a slow gesture
results in a "settle" animation.

[abarth-chromium, 2014-01-07 20:26:42]

+ojan

[Dominik Grewe, 2014-01-08 15:36:04]

On 2014/01/07 20:26:27, abarth wrote:
> Makes sense.  Should I wait for that CL to land, or should I iterate on this
> action after landing this CL?  For context, I expect to iterate on
> app-drawer.html in the future.  I'm mostly interested in getting an end-to-end
> example working so that Ojan and I can scale it up.

The CL is currently in the CQ, so it should land soon.


> Related question: I'm surprised there isn't a "duration" or "speed" attribute
> for swipe.  I was expecting to be able to control how quickly gesture
proceeded.
>  For example, a fast gesture results in a "fling" animation and a slow gesture
> results in a "settle" animation.

I was planning to add a fling action to Telemetry, and as part of that CL expose
a speed parameter to swipe. But there are some complications in getting
consistent flings, so I've uploaded a separate CL to add a speed parameter to
swipe and scroll (https://codereview.chromium.org/128073002/).

[abarth-chromium, 2014-01-08 16:45:16]

On 2014/01/08 15:36:04, Dominik Grewe wrote:
> I was planning to add a fling action to Telemetry, and as part of that CL
expose
> a speed parameter to swipe. But there are some complications in getting
> consistent flings, so I've uploaded a separate CL to add a speed parameter to
> swipe and scroll (https://codereview.chromium.org/128073002/).

Thanks.  The test computes the fling itself, so it just needs the lower-level
touch events.

[abarth-chromium, 2014-01-08 19:31:21]

wait_after is pretty cool!  Thanks.

[commit-bot: I haz the power, 2014-01-08 19:33:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/120753003/100001

[commit-bot: I haz the power, 2014-01-08 21:36:36]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2014-01-08 22:12:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/120753003/370001

[commit-bot: I haz the power, 2014-01-08 23:23:45]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2014-01-08 23:34:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/120753003/370001

[commit-bot: I haz the power, 2014-01-09 01:12:12]

Change committed as 243722