Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(52)

Issue 1207463002: Blank assets for staging new media UI. (Closed)

Created:
4 years, 10 months ago by liberato (no reviews please)
Modified:
4 years, 10 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, rwlbuis, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Blank assets for staging new media UI. This CL adds new zero-length png and css assets, so that they can be referenced in blink_platform_impl.cc (etc.) for staging, before the main CL in WebKit lands. This CL does not change any existing functionality. BUG=446350, 488625, 487344 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197823

Patch Set 1 #

Patch Set 2 : zero length assets don't patch. now with one free character. #

Patch Set 3 : added grd files. #

Patch Set 4 : 1x1 pngs, since grd tools require it. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, --2 lines) Patch
A + Source/core/css/mediaControlsAndroidNew.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/css/mediaControlsNew.css View 0 chunks +-1 lines, --1 lines 0 comments Download
M public/blink_image_resources.grd View 1 2 3 2 chunks +14 lines, -0 lines 0 comments Download
M public/blink_resources.grd View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A public/default_100_percent/blink/1x1.png View 1 2 3 Binary file 0 comments Download

Messages

Total messages: 11 (2 generated)
liberato (no reviews please)
these are just the assets to help stage the new media playback UI changes. once ...
4 years, 10 months ago (2015-06-23 16:53:24 UTC) #2
jochen (gone - plz use gerrit)
are the css files empty on purpose?
4 years, 10 months ago (2015-06-24 14:46:09 UTC) #3
liberato (no reviews please)
On 2015/06/24 14:46:09, jochen wrote: > are the css files empty on purpose? yes, they're ...
4 years, 10 months ago (2015-06-24 15:01:56 UTC) #4
liberato (no reviews please)
added missing grd files to reference the blank assets. thanks -fl
4 years, 10 months ago (2015-06-24 15:06:54 UTC) #5
liberato (no reviews please)
replaced everything with 1x1 pngs (67 bytes), since grit didn't like nonzero files that aren't ...
4 years, 10 months ago (2015-06-24 16:02:12 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2015-06-25 09:29:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207463002/60001
4 years, 10 months ago (2015-06-25 15:03:41 UTC) #9
liberato (no reviews please)
On 2015/06/25 09:29:54, jochen wrote: > lgtm thanks! -fl
4 years, 10 months ago (2015-06-25 15:04:06 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 15:07:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197823

Powered by Google App Engine
This is Rietveld 408576698