Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Side by Side Diff: sky/tools/skyanalyzer

Issue 1207453003: Silence some analyzer warnings (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2014 The Chromium Authors. All rights reserved. 2 # Copyright 2014 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import argparse 6 import argparse
7 import os 7 import os
8 import re 8 import re
9 import subprocess 9 import subprocess
10 import sys 10 import sys
(...skipping 12 matching lines...) Expand all
23 23
24 # Ignored because they don't affect Sky code 24 # Ignored because they don't affect Sky code
25 re.compile(r'\[hint\] When compiled to JS, this test might return true when th e left hand side is an int'), 25 re.compile(r'\[hint\] When compiled to JS, this test might return true when th e left hand side is an int'),
26 26
27 # TODO: Remove once sdk-extensions are in place 27 # TODO: Remove once sdk-extensions are in place
28 re.compile(r'^\[error\] Native functions can only be declared in'), 28 re.compile(r'^\[error\] Native functions can only be declared in'),
29 29
30 # TODO: Fix all the warnings in the mojo packages 30 # TODO: Fix all the warnings in the mojo packages
31 re.compile(r'.*/dart-pkg/mojom/'), 31 re.compile(r'.*/dart-pkg/mojom/'),
32 re.compile(r'.*/dart-pkg/mojo/'), 32 re.compile(r'.*/dart-pkg/mojo/'),
33 re.compile(r'.*/mojo/public/dart/'),
33 34
34 # TODO: Remove this once Sky no longer generates this warning. 35 # TODO: Remove this once Sky no longer generates this warning.
35 # dartbug.com/22836 36 # dartbug.com/22836
36 re.compile(r'.*cannot both be unnamed'), 37 re.compile(r'.*cannot both be unnamed'),
37 38
38 # TODO: Remove this once Sky no longer generates this warning. 39 # TODO: Remove this once Sky no longer generates this warning.
39 # dartbug.com/23606 40 # dartbug.com/23606
40 re.compile(r'^\[warning] Missing concrete implementation of \'RenderObject.toS tring\''), 41 re.compile(r'^\[warning] Missing concrete implementation of \'RenderObject.toS tring\''),
41 ] 42 ]
42 43
(...skipping 29 matching lines...) Expand all
72 print >> sys.stderr, error 73 print >> sys.stderr, error
73 # Propagate analyzer error code. 74 # Propagate analyzer error code.
74 return e.returncode 75 return e.returncode
75 # If we do not have any errors left after filtering, return 0. 76 # If we do not have any errors left after filtering, return 0.
76 if args.congratulate: 77 if args.congratulate:
77 print >> sys.stdout, "No analyzer warnings!" 78 print >> sys.stdout, "No analyzer warnings!"
78 return 0 79 return 0
79 80
80 if __name__ == '__main__': 81 if __name__ == '__main__':
81 sys.exit(main()) 82 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698