Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 1207453002: Fixed exception handling in Realm.create(). (Closed)

Created:
5 years, 6 months ago by Igor Sheludko
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fixed exception handling in Realm.create(). BUG=chromium:501711 LOG=N Committed: https://crrev.com/bcb276c6f7bf14418857f6db9296d50b711a6978 Cr-Commit-Position: refs/heads/master@{#29236}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M src/api.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/d8.cc View 2 chunks +8 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-501711.js View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Igor Sheludko
PTAL
5 years, 6 months ago (2015-06-23 14:44:10 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-23 14:50:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207453002/20001
5 years, 6 months ago (2015-06-23 14:57:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 6 months ago (2015-06-23 15:08:48 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bcb276c6f7bf14418857f6db9296d50b711a6978 Cr-Commit-Position: refs/heads/master@{#29236}
5 years, 6 months ago (2015-06-23 15:09:03 UTC) #8
adamk
5 years, 6 months ago (2015-06-23 22:30:10 UTC) #10
Message was sent while issue was closed.
The test included in this patch fails consistently under arm64 nosnap debug:

http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20s...

Powered by Google App Engine
This is Rietveld 408576698