Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1207393002: Return GrGLContext from GrTestTarget (Closed)

Created:
5 years, 6 months ago by joshua.litt
Modified:
5 years, 6 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Return GrGLContext from GrTestTarget BUG=skia: Committed: https://skia.googlesource.com/skia/+/b6d93ea428ca5d13641c35faca7d0380980a3a17

Patch Set 1 #

Patch Set 2 : make GrGLContext refcnted #

Patch Set 3 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M gm/imagefromyuvtextures.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrGpu.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrTest.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 2 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLContext.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
joshualitt
ptal Should I make GrGLContext refcnted?
5 years, 6 months ago (2015-06-25 19:39:21 UTC) #2
joshualitt
feedback inc
5 years, 6 months ago (2015-06-25 20:40:56 UTC) #3
bsalomon
lgtm
5 years, 6 months ago (2015-06-25 21:10:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207393002/40001
5 years, 6 months ago (2015-06-25 21:50:37 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/b6d93ea428ca5d13641c35faca7d0380980a3a17
5 years, 6 months ago (2015-06-25 22:02:27 UTC) #7
reed2
5 years, 6 months ago (2015-06-26 01:59:11 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1211123004/ by reed@chromium.org.

The reason for reverting is: speculative revert to unblock DEPS roll
(layout-tests).

Powered by Google App Engine
This is Rietveld 408576698