Convert display_unittests to run exclusively on Swarming

Convert display_unittests to run exclusively on Swarming

0 configs already ran on Swarming
15 used to run locally and were converted:
- chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1)
- chromium.chromiumos.json: Linux ChromiumOS Tests (1)
- chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1)
- chromium.fyi.json: Linux Trusty
- chromium.fyi.json: Linux Trusty (dbg)
- chromium.linux.json: Linux Tests
- chromium.linux.json: Linux Tests (dbg)(1)
- chromium.linux.json: Linux Tests (dbg)(1)(32)
- chromium.memory.fyi.json: Linux ChromeOS MSan Tests
- chromium.memory.fyi.json: Linux MSan Tests
- chromium.memory.fyi.json: Linux TSan Tests
- chromium.memory.json: Linux ASan LSan Tests (1)
- chromium.memory.json: Linux Chromium OS ASan LSan Tests (1)
- chromium.webkit.json: Linux ChromiumOS Tests (1)
- chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1)

Ran:
  ./manage.py --convert display_unittests

R=oshima@chromium.org,thakis@chromium.org
BUG=98637
Committed: https://crrev.com/b3da857eaa84821c47719a9ebe9c464aedbe02c7
Cr-Commit-Position: refs/heads/master@{#338370}

[Nico, 2015-07-03 21:15:34]

It tries to package out/Debug/gen/out/Debug/display_unittests (note duplicate
out/Debug, also weird gen) on the linux bots (e.g.
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
). Not sure what's wrong?

[M-A Ruel, 2015-07-07 01:58:28]

On 2015/07/03 21:15:34, Nico wrote:
> It tries to package out/Debug/gen/out/Debug/display_unittests (note duplicate
> out/Debug, also weird gen) on the linux bots (e.g.
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
> ). Not sure what's wrong?

The .isolate was malformed. Fixed.

[Nico, 2015-07-07 02:51:59]

lgtm

That's a surprising error message for a nested variable block.

Do you need the test_env stuff?

[oshima, 2015-07-07 18:50:23]

ui/display lgtm

[M-A Ruel, 2015-07-10 20:28:49]

On 2015/07/07 02:51:59, Nico wrote:
> lgtm
> 
> That's a surprising error message for a nested variable block.
> 
> Do you need the test_env stuff?

I prefer it to be used everywhere by default to the test do not unexpectedly
fail on non-English system (e.g. locally). It also sets up the sanitizer.

[M-A Ruel, 2015-07-10 20:29:17]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2015-07-10 20:30:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1207383007/40001

[Nico, 2015-07-10 20:34:59]

if you want that everywhere, maybe the isolate system should inject it
somehow instead of hoping that every single .isolate file gets it right?

On Fri, Jul 10, 2015 at 1:30 PM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1207383007/40001
>
>
> https://codereview.chromium.org/1207383007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[M-A Ruel, 2015-07-10 21:09:28]

On 2015/07/10 20:34:59, Nico wrote:
> if you want that everywhere, maybe the isolate system should inject it
> somehow instead of hoping that every single .isolate file gets it right?

Isolate doesn't know about chromium and shouldn't. Also many tests may not use
this script on purpose.

[Nico, 2015-07-10 21:12:38]

On Fri, Jul 10, 2015 at 2:09 PM, <maruel@chromium.org> wrote:

> On 2015/07/10 20:34:59, Nico wrote:
>
>> if you want that everywhere, maybe the isolate system should inject it
>> somehow instead of hoping that every single .isolate file gets it right?
>>
>
> Isolate doesn't know about chromium and shouldn't. Also many tests may not
> use
> this script on purpose.
>

Isolate itself shouldn't know about this of course, but there could be some
wrapper in the chrome repo that checks that chrome-isms are done correctly.
As is, I guarantee that there are 10+ isolate files that should use this
script but don't.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[M-A Ruel, 2015-07-10 21:26:43]

It likely break the symbolization of crashes for these platforms but likely
nobody will notice until it's crashing. Also only a small subset of tests
run on asan/tsan/msan.

M-A

2015-07-10 15:12 GMT-06:00 Nico Weber <thakis@chromium.org>:

> On Fri, Jul 10, 2015 at 2:09 PM, <maruel@chromium.org> wrote:
>
>> On 2015/07/10 20:34:59, Nico wrote:
>>
>>> if you want that everywhere, maybe the isolate system should inject it
>>> somehow instead of hoping that every single .isolate file gets it right?
>>>
>>
>> Isolate doesn't know about chromium and shouldn't. Also many tests may
>> not use
>> this script on purpose.
>>
>
> Isolate itself shouldn't know about this of course, but there could be
> some wrapper in the chrome repo that checks that chrome-isms are done
> correctly. As is, I guarantee that there are 10+ isolate files that should
> use this script but don't.
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2015-07-10 21:28:14]

Right; those are the most annoying bugs (the ones you don't notice until
you're already in a bind)

On Fri, Jul 10, 2015 at 2:26 PM, Marc-Antoine Ruel <maruel@chromium.org>
wrote:

> It likely break the symbolization of crashes for these platforms but
> likely nobody will notice until it's crashing. Also only a small subset of
> tests run on asan/tsan/msan.
>
> M-A
>
> 2015-07-10 15:12 GMT-06:00 Nico Weber <thakis@chromium.org>:
>
>> On Fri, Jul 10, 2015 at 2:09 PM, <maruel@chromium.org> wrote:
>>
>>> On 2015/07/10 20:34:59, Nico wrote:
>>>
>>>> if you want that everywhere, maybe the isolate system should inject it
>>>> somehow instead of hoping that every single .isolate file gets it right?
>>>>
>>>
>>> Isolate doesn't know about chromium and shouldn't. Also many tests may
>>> not use
>>> this script on purpose.
>>>
>>
>> Isolate itself shouldn't know about this of course, but there could be
>> some wrapper in the chrome repo that checks that chrome-isms are done
>> correctly. As is, I guarantee that there are 10+ isolate files that should
>> use this script but don't.
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-07-10 21:43:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-10 21:44:29]

Patchset 3 (id:??) landed as
https://crrev.com/b3da857eaa84821c47719a9ebe9c464aedbe02c7
Cr-Commit-Position: refs/heads/master@{#338370}