Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: chrome/browser/engagement/site_engagement_service_unittest.cc

Issue 1207383006: Add GetTotalEngagementPoints to SiteEngagementService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address_comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_service_unittest.cc
diff --git a/chrome/browser/engagement/site_engagement_service_unittest.cc b/chrome/browser/engagement/site_engagement_service_unittest.cc
index 0bc9543df3829cc1a471e582182f99ece05f6fab..728239bc150de9e07296f753dad5f8ad7a94328b 100644
--- a/chrome/browser/engagement/site_engagement_service_unittest.cc
+++ b/chrome/browser/engagement/site_engagement_service_unittest.cc
@@ -334,3 +334,40 @@ TEST_F(SiteEngagementServiceTest, ScoreIncrementsOnPageRequest) {
NavigateAndCommitActiveTab(url);
EXPECT_LT(prev_score, service->GetScore(url));
}
+
+// Expect that site engagement
raymes 2015/07/06 02:50:51 nit: this comment looks unfinished
calamity 2015/07/07 02:47:25 Oops.
+TEST_F(SiteEngagementServiceTest, GetTotalEngagementPoints) {
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kEnableSiteEngagementService);
raymes 2015/07/06 02:50:51 nit: we should probably just move this into SetUp(
calamity 2015/07/07 02:47:25 Done.
+
+ SiteEngagementService* service =
+ SiteEngagementServiceFactory::GetForProfile(profile());
+ DCHECK(service);
+
+ // The https and http versions of www.google.com should be separate.
+ GURL url1("https://www.google.com/");
+ GURL url2("http://www.google.com/");
+ GURL url3("http://m.xkcd.com/");
+
+ EXPECT_EQ(0, service->GetScore(url1));
+ EXPECT_EQ(0, service->GetScore(url2));
+ EXPECT_EQ(0, service->GetScore(url3));
+
+ service->HandleNavigation(url1);
+ EXPECT_EQ(1, service->GetScore(url1));
+ EXPECT_EQ(1, service->GetTotalEngagementPoints());
+
+ service->HandleNavigation(url2);
+ service->HandleNavigation(url2);
+ EXPECT_EQ(2, service->GetScore(url2));
+ EXPECT_EQ(3, service->GetTotalEngagementPoints());
+
+ service->HandleNavigation(url3);
+ EXPECT_EQ(1, service->GetScore(url3));
+ EXPECT_EQ(4, service->GetTotalEngagementPoints());
+
+ service->HandleNavigation(url1);
+ service->HandleNavigation(url1);
+ EXPECT_EQ(3, service->GetScore(url1));
+ EXPECT_EQ(6, service->GetTotalEngagementPoints());
+}

Powered by Google App Engine
This is Rietveld 408576698