Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5570)

Unified Diff: chrome/browser/engagement/site_engagement_service_unittest.cc

Issue 1207383006: Add GetTotalEngagementPoints to SiteEngagementService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_service_unittest.cc
diff --git a/chrome/browser/engagement/site_engagement_service_unittest.cc b/chrome/browser/engagement/site_engagement_service_unittest.cc
index 0bc9543df3829cc1a471e582182f99ece05f6fab..5a5ee39d55d6a70bd3879a74e6198d7903b90ef0 100644
--- a/chrome/browser/engagement/site_engagement_service_unittest.cc
+++ b/chrome/browser/engagement/site_engagement_service_unittest.cc
@@ -326,11 +326,15 @@ TEST_F(SiteEngagementServiceTest, ScoreIncrementsOnPageRequest) {
AddTab(browser(), GURL("about:blank"));
EXPECT_EQ(0, service->GetScore(url));
int prev_score = service->GetScore(url);
+ int prev_total_score = service->GetTotalEngagementPoints();
NavigateAndCommitActiveTab(url);
EXPECT_LT(prev_score, service->GetScore(url));
prev_score = service->GetScore(url);
+ EXPECT_LT(prev_total_score, service->GetTotalEngagementPoints());
+ prev_total_score = service->GetTotalEngagementPoints();
NavigateAndCommitActiveTab(url);
EXPECT_LT(prev_score, service->GetScore(url));
+ EXPECT_LT(prev_total_score, service->GetTotalEngagementPoints());
}
raymes 2015/07/01 05:33:09 Could we add a new test where we browse to a bunch
calamity 2015/07/06 01:51:06 Yep, I just needed to check with benwells why this

Powered by Google App Engine
This is Rietveld 408576698