Add GetTotalEngagementPoints to SiteEngagementService.

chrome/browser/engagement/site_engagement_service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/engagement/site_engagement_service.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/command_line.h"
@@ skipping 14 matching lines @@
 
 // Delta within which to consider internal time values equal. Internal time
 // values are in microseconds, so this delta comes out at one second.
 const double kTimeDelta = 1000000;
 
 bool DoublesConsideredDifferent(double value1, double value2, double delta) {
   double abs_difference = fabs(value1 - value2);
   return abs_difference > delta;
 }
 
 scoped_ptr<base::DictionaryValue> GetOriginDict(

[raymes, 2015/07/01 05:33:09]

How about we rename this GetScoreDict or GetScoreDictForOrigin? I think it would
make things a bit clearer

[calamity, 2015/07/06 01:51:06]

Done.

     HostContentSettingsMap* settings,
     const GURL& origin_url) {
   if (!settings)
     return scoped_ptr<base::DictionaryValue>();
 
   scoped_ptr<base::Value> value = settings->GetWebsiteSetting(
       origin_url, origin_url, CONTENT_SETTINGS_TYPE_SITE_ENGAGEMENT,
       std::string(), NULL);
   if (!value.get())
     return make_scoped_ptr(new base::DictionaryValue());
@@ skipping 139 matching lines @@
 }
 
 int SiteEngagementService::GetScore(const GURL& url) {
   HostContentSettingsMap* settings_map = profile_->GetHostContentSettingsMap();
   scoped_ptr<base::DictionaryValue> settings = GetOriginDict(settings_map, url);
   SiteEngagementScore score(&clock_, *settings);
 
   return score.Score();
 }
 
+int SiteEngagementService::GetTotalEngagementPoints() {
+  HostContentSettingsMap* settings_map = profile_->GetHostContentSettingsMap();
+  ContentSettingsForOneType engagement_settings;
+  settings_map->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_SITE_ENGAGEMENT,
+                                      std::string(), &engagement_settings);
+  int total_score = 0;
+  for (auto it : engagement_settings) {

[raymes, 2015/07/01 05:33:08]

perhaps 
for (auto site : engagement_settings)

Also I think you can use "const auto& site" here to just grab a reference.

[calamity, 2015/07/06 01:51:06]

Done.

+    scoped_ptr<base::DictionaryValue> settings =
+        GetOriginDict(settings_map, GURL(it.primary_pattern.ToString()));

[raymes, 2015/07/01 05:33:09]

I guess we should technically check that the GURL is valid first (since
ContentSettingsPattern isn't necessarily a url (it may be a pattern). In our
case it /should/ be a URL but there isn't anything that enforces that (and it's
being read from a pref on disk) so we should check.

[calamity, 2015/07/06 01:51:06]

Done.

+    SiteEngagementScore score(&clock_, *settings);
+    total_score += score.Score();
+  }
+  return total_score;
+}