Issue 1207383003: Land the correct icons for web app banner info bars on desktop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1207383003: Land the correct icons for web app banner info bars on desktop. (Closed)

Created:
5 years, 6 months ago by dominickn

Modified:
5 years, 6 months ago

Reviewers:
oshima

CC:
chromium-reviews, oshima+watch_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Land the correct icons for web app banner info bars on desktop. These infobars currently use a placeholder icon. Update this placeholder to the icons specified in the mocks. BUG=491001 R=oshima@chromium.org Committed: https://crrev.com/efa40ebbd4038b249008023ec74c39687fe4843e Cr-Commit-Position: refs/heads/master@{#336308}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -2 lines)			Patch
A	chrome/app/theme/default_100_percent/common/infobar_apps.png	View	Binary file		0 comments	Download
A	chrome/app/theme/default_200_percent/common/infobar_apps.png	View	Binary file		0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

dominickn

Please review and let me know if this is the correct way to land binary ...

5 years, 6 months ago (2015-06-25 23:07:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207383003/1

5 years, 6 months ago (2015-06-26 00:35:30 UTC) #4

commit-bot: I haz the power

5 years, 6 months ago (2015-06-26 01:18:46 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/efa40ebbd4038b249008023ec74c39687fe4843e
Cr-Commit-Position: refs/heads/master@{#336308}