Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1207373005: Add some dartdoc comments (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add some dartdoc comments This CL is an experiment in adding some dartdoc comments in a few places. It's unclear how extensively we'll use dartdoc. TBR=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c0a1b3bc363413a15f2a6247521168c2a9c25331

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -9 lines) Patch
M sky/sdk/lib/widgets/card.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/checkbox.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/dialog.dart View 3 chunks +15 lines, -2 lines 2 comments Download
M sky/sdk/lib/widgets/widget.dart View 5 chunks +26 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-08 04:38:54 UTC) #1
abarth-chromium
Committed patchset #1 (id:1) manually as c0a1b3bc363413a15f2a6247521168c2a9c25331 (presubmit successful).
5 years, 5 months ago (2015-07-08 04:39:30 UTC) #2
Hixie
lgtm https://codereview.chromium.org/1207373005/diff/1/sky/sdk/lib/widgets/dialog.dart File sky/sdk/lib/widgets/dialog.dart (right): https://codereview.chromium.org/1207373005/diff/1/sky/sdk/lib/widgets/dialog.dart#newcode23 sky/sdk/lib/widgets/dialog.dart:23: /// The (optional) title of the dialog is ...
5 years, 5 months ago (2015-07-08 15:10:57 UTC) #3
abarth-chromium
5 years, 5 months ago (2015-07-08 15:29:29 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/1207373005/diff/1/sky/sdk/lib/widgets/dialog....
File sky/sdk/lib/widgets/dialog.dart (right):

https://codereview.chromium.org/1207373005/diff/1/sky/sdk/lib/widgets/dialog....
sky/sdk/lib/widgets/dialog.dart:23: /// The (optional) title of the dialog is
displayed in a large font at the top
On 2015/07/08 at 15:10:57, Hixie wrote:
> This is an interesting convention (putting the documentation on the fields,
rather than on the constructor). What does the output look like? Is it clear
that these really refer to the constructor arguments?

I was just experimenting with different approaches.  I'm not sure happy with how
any of them look.  I'll show you in person what the output looks like.

> If we document these, we're gonna have to reconsider making the (mutable)
fields public on StatefulComponents.

Powered by Google App Engine
This is Rietveld 408576698