Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1207373002: Implement Mac Keychain migration algorithm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« crypto/mock_apple_keychain.h ('K') | « crypto/mock_apple_keychain_mac.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 36452aa5c26c270e116b87468e7b6d6c86212d23..89e7629e291b79ef7792082e5969f2d585d42562 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -27677,6 +27677,31 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram
+ name="PasswordManager.KeychainMigration.NumChromeOwnedLockedPasswords">
Ilya Sherman 2015/06/25 21:46:25 nit: Probably mention "failure" somewhere in the h
vasilii 2015/06/26 12:18:48 Done.
+ <owner>vasilii@chromium.org</owner>
+ <summary>
+ After migration from Mac Keychain failed, it contains amount of passwords
+ owned by Chrome but not accessible by it.
Ilya Sherman 2015/06/25 21:46:25 nit: Suggested phrasing: "After migration from the
vasilii 2015/06/26 12:18:48 Done.
+ </summary>
+</histogram>
+
+<histogram name="PasswordManager.KeychainMigration.NumLockedPasswords">
+ <owner>vasilii@chromium.org</owner>
+ <summary>
+ After migration from Mac Keychain failed, it contains amount of passwords
+ not accessible by Chrome.
+ </summary>
+</histogram>
+
+<histogram name="PasswordManager.KeychainMigration.NumPasswords">
+ <owner>vasilii@chromium.org</owner>
+ <summary>
+ After migration from Mac Keychain failed, it contains amount of passwords in
+ the Chrome Password Manager.
Ilya Sherman 2015/06/25 21:46:25 Is it worth having a (set of) success histogram(s)
vasilii 2015/06/26 12:18:48 Sure. I'll add one in another patch. It will recor
+ </summary>
+</histogram>
+
<histogram name="PasswordManager.KWalletDeserializationStatus"
enum="BooleanSuccess">
<owner>gcasto@chromium.org</owner>
« crypto/mock_apple_keychain.h ('K') | « crypto/mock_apple_keychain_mac.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698