Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1207353004: Revert of Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (Closed)

Created:
5 years, 5 months ago by jvanverth1
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (patchset #1 id:1 of https://codereview.chromium.org/1219193002/) Reason for revert: Blocking the roll Original issue's description: > Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (patchset #2 id:30001 of https://codereview.chromium.org/1210053003/) > > Reason for revert: > Perf regression: https://code.google.com/p/chromium/issues/detail?id=505564 > > Original issue's description: > > Fix SkTileImageFilter clipping/cropRect interaction issue > > > > BUG=499499 > > > > Committed: https://skia.googlesource.com/skia/+/157bcd0840b578060dbc3365daafffc6837da391 > > TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,robertphillips@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=499499 > > Committed: https://skia.googlesource.com/skia/+/ebaf6a69bf604c85185e23aca3fb93308e747ff5 TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,robertphillips@google.com,reed@chromium.org,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=499499 Committed: https://skia.googlesource.com/skia/+/835510085062f055c04d8ea46d82831cfbe51793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -12 lines) Patch
A gm/cropdisp.cpp View 1 chunk +105 lines, -0 lines 0 comments Download
M include/core/SkImageFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +31 lines, -0 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/effects/SkTileImageFilter.cpp View 3 chunks +20 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jvanverth1
Created Revert of Revert of Fix SkTileImageFilter clipping/cropRect interaction issue
5 years, 5 months ago (2015-07-03 12:48:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207353004/1
5 years, 5 months ago (2015-07-03 12:48:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/835510085062f055c04d8ea46d82831cfbe51793
5 years, 5 months ago (2015-07-03 12:48:57 UTC) #3
robertphillips
5 years, 5 months ago (2015-07-06 14:58:58 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1217303004/ by robertphillips@google.com.

The reason for reverting is: Still want to disable due to pref regression.

Powered by Google App Engine
This is Rietveld 408576698