chrome/renderer/extensions/safe_builtins.cc - Issue 120733003: Feature detection-friendly restrictions for packaged apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/safe_builtins.cc

Issue 120733003: Feature detection-friendly restrictions for packaged apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated broken test. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/extensions/safe_builtins.cc

diff --git a/chrome/renderer/extensions/safe_builtins.cc b/chrome/renderer/extensions/safe_builtins.cc

index 5ba46a34cfa12c4a14b558a37eb7da551a2143a7..62bd8700bb8652779e614bb8ae67cfb62a1b4295 100644

--- a/chrome/renderer/extensions/safe_builtins.cc

+++ b/chrome/renderer/extensions/safe_builtins.cc

@@ -66,7 +66,8 @@ const char kScript[] =

"// Save only what is needed to make tests that override builtins pass.\n"

"saveBuiltin(Object,\n"

" ['hasOwnProperty'],\n"

- " ['getPrototypeOf', 'keys']);\n"

+ " ['defineProperty', 'getOwnPropertyDescriptor',\n"

+ " 'getPrototypeOf', 'keys']);\n"

"saveBuiltin(Function,\n"

" ['apply', 'bind', 'call']);\n"

"saveBuiltin(Array,\n"

« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/platform_app.js » ('j') | chrome/renderer/resources/extensions/platform_app.js » ('J')