chrome/test/data/extensions/platform_apps/restrictions/sandboxed_iframe.js - Issue 120733003: Feature detection-friendly restrictions for packaged apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/restrictions/sandboxed_iframe.js

Issue 120733003: Feature detection-friendly restrictions for packaged apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed feedback. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/platform_apps/restrictions/main.js ('k') | chrome/test/data/extensions/platform_apps/storage/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/restrictions/sandboxed_iframe.js

diff --git a/chrome/test/data/extensions/platform_apps/restrictions/sandboxed_iframe.js b/chrome/test/data/extensions/platform_apps/restrictions/sandboxed_iframe.js

index 08893bbffa334354c26ed7aa45f7eeb29ce01bb7..a71bc9f43403dc615002ddb34330594e42efa299 100644

--- a/chrome/test/data/extensions/platform_apps/restrictions/sandboxed_iframe.js

+++ b/chrome/test/data/extensions/platform_apps/restrictions/sandboxed_iframe.js

@@ -3,17 +3,16 @@

// found in the LICENSE file.

window.onload = function() {

- try {

- window.alert('should throw');

+ window.onunload = function() {

window.parent.postMessage({'success': false,

- 'reason' : 'should have thrown'},

+ 'reason' : 'unload handler works'},

'*');

- } catch(e) {

- var message = e.message || e;

- var succ = message.indexOf('is not available in packaged apps') != -1;

- window.parent.postMessage({'success': succ,

- 'reason' : 'got wrong error: ' + message},

+ };

+ if (typeof(window.unload) !== 'undefined') {

+ window.parent.postMessage({'success': false,

+ 'reason' : 'unload is not undefined'},

'*');

}

+ window.dispatchEvent(new Event('unload'));

+ window.parent.postMessage({'success': true}, '*');

};