chrome/browser/ui/views/certificate_selector.cc - Issue 1207313003: Allow cert-popup for WebView guests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/certificate_selector.cc

Issue 1207313003: Allow cert-popup for WebView guests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/certificate_selector.cc

diff --git a/chrome/browser/ui/views/certificate_selector.cc b/chrome/browser/ui/views/certificate_selector.cc

index d2d5afb7efdd76ad6fb720c4fa4def035e56206c..ead471ba0e7705aca379cb8940497d515a578cc8 100644

--- a/chrome/browser/ui/views/certificate_selector.cc

+++ b/chrome/browser/ui/views/certificate_selector.cc

@@ -87,6 +87,11 @@ CertificateSelector::~CertificateSelector() {

table_->SetModel(nullptr);

}

+// Static.

+bool CertificateSelector::CanShow(content::WebContents* web_contents) {

+ return constrained_window::HasTopLevelDialogManager(web_contents);

void CertificateSelector::Show() {

constrained_window::ShowWebModalDialogViews(this, web_contents_);