initial sync*, part of #221

initial sync*, part of #221

Right now it maps straight to ES6 generators. This should handle some basic cases, but there's more work to get all of the corners working. For example: it doesn't implement Iterable yet.

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/06e98b6d0f89c731e283cc4ab90becabe9fe92e2

[Jennifer Messerly, 2015-06-25 18:16:42]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2015-06-25 18:17:45]

https://codereview.chromium.org/1207313002/diff/1/lib/runtime/dart/_isolate_h...
File lib/runtime/dart/_isolate_helper.js (left):

https://codereview.chromium.org/1207313002/diff/1/lib/runtime/dart/_isolate_h...
lib/runtime/dart/_isolate_helper.js:614: let respond = () => {
this is a rework of my previous FunctionDeclarationStatement bind-this fix.
Instead we keep them as functions (works better for `function*`), and bind(this)
if needed.

https://codereview.chromium.org/1207313002/diff/1/lib/runtime/dart/_isolate_h...
File lib/runtime/dart/_isolate_helper.js (right):

https://codereview.chromium.org/1207313002/diff/1/lib/runtime/dart/_isolate_h...
lib/runtime/dart/_isolate_helper.js:505: let func = (function(f, a) {
we seemed to have precedence wrong for these... surprised we didn't hit this

https://codereview.chromium.org/1207313002/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1207313002/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:1216: // We need to bind
oops, removing this.

https://codereview.chromium.org/1207313002/diff/1/lib/src/js/precedence.dart
File lib/src/js/precedence.dart (right):

https://codereview.chromium.org/1207313002/diff/1/lib/src/js/precedence.dart#...
lib/src/js/precedence.dart:9: const YIELD = SPREAD + 1;
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/O...

[Jennifer Messerly, 2015-06-25 19:34:37]

btw, the old CL for FunctionDeclarationStatement was:
https://codereview.chromium.org/1132113003/diff/1/lib/src/codegen/js_codegen....

[Jennifer Messerly, 2015-06-25 23:27:33]

fyi, I'm continuing to work from this, adding async/async*. One thing I might
change there is make sure we wrap the generator in an Iterable<T> object. See
https://github.com/dart-lang/dev_compiler/issues/247 for more context

[vsm, 2015-06-26 13:47:39]

lgtm

Are the new files (expect, tests) from the main repo?  Perhaps we should we
start tracking what we're copying from where?

[Jennifer Messerly, 2015-06-26 15:47:30]

On 2015/06/26 13:47:39, vsm wrote:
> lgtm
> 
> Are the new files (expect, tests) from the main repo?  Perhaps we should we
> start tracking what we're copying from where?

yeah, 2 of them are, one of them I wrote. I put in a TODO for the two from the
SDK repo ... not sure if there's a better way to track

[Jennifer Messerly, 2015-06-26 23:02:34]

Committed patchset #3 (id:40001) manually as
06e98b6d0f89c731e283cc4ab90becabe9fe92e2 (presubmit successful).