Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1207283002: MIPS: Followup to '[turbofan] Add basic support for calling to (a subset of) C functions.'

Created:
5 years, 6 months ago by balazs.kilvady
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Followup to '[turbofan] Add basic support for calling to (a subset of) C functions.' Port a58ba8d80179bf5b6b7245590c82e47fda8c8a5e Original commit message: This introduces some initial building blocks for calling out to C/C++ functions directly from TurboFan generated code objects. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/compiler/mips/linkage-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
paul.l...
5 years, 6 months ago (2015-06-26 04:58:41 UTC) #2
I don't understand the motivation to move away from the range-based for loops in
https://codereview.chromium.org/1205023002/.

Note that he moved away only in the case of the Poke loops, where they used
MiscField::encode(slot). We do not use that, we use slot as an immediate value.
But we _do_ use slot for _both_ the the C-call and JS-call for loops. So my
opinion is that we should change both or neither.

Unless it is clear to you, you might want to ask via email.

Powered by Google App Engine
This is Rietveld 408576698