Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issue 120723006: In Chromium, App Launcher's WM_CLASS is "chromium_app_list". (Closed)

Created:
6 years, 11 months ago by Matt Giuca
Modified:
6 years, 11 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

In Chromium, App Launcher's WM_CLASS is "chromium_app_list". It was previously "chrome_app_list" regardless of which build we are in. BUG=331729 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/ui/views/app_list/linux/app_list_service_linux.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Matt Giuca
6 years, 11 months ago (2014-01-06 06:02:56 UTC) #1
koz (OOO until 15th September)
lgtm
6 years, 11 months ago (2014-01-06 23:11:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/120723006/1
6 years, 11 months ago (2014-01-06 23:46:12 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242295
6 years, 11 months ago (2014-01-07 11:30:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/120723006/1
6 years, 11 months ago (2014-01-07 23:13:32 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 00:55:19 UTC) #6
Message was sent while issue was closed.
Change committed as 243453

Powered by Google App Engine
This is Rietveld 408576698