Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/service.cc

Issue 120723003: Refactors CPU feature detection. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Cleanup Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/cpuinfo_android.cc ('K') | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/simulator_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
===================================================================
--- runtime/vm/service.cc (revision 31402)
+++ runtime/vm/service.cc (working copy)
@@ -517,7 +517,8 @@
static void HandleCpu(Isolate* isolate, JSONStream* js) {
JSONObject jsobj(js);
jsobj.AddProperty("type", "CPU");
- jsobj.AddProperty("architecture", CPU::Id());
+ jsobj.AddProperty("built-for", CPU::Id());
Cutch 2014/01/02 19:39:19 please use "fooBar" or "foo_bar" for property name
zra 2014/01/13 21:57:19 Done.
+ jsobj.AddProperty("running-on", CPUFeatures::hardware());
}
« runtime/vm/cpuinfo_android.cc ('K') | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/simulator_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698