Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1198)

Unified Diff: runtime/vm/cpu_mips.cc

Issue 120723003: Refactors CPU feature detection. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Cleanup Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/cpu_mips.cc
===================================================================
--- runtime/vm/cpu_mips.cc (revision 31402)
+++ runtime/vm/cpu_mips.cc (working copy)
@@ -6,14 +6,16 @@
#if defined(TARGET_ARCH_MIPS)
+#include "vm/cpu.h"
+#include "vm/cpuinfo.h"
+#include "vm/simulator.h"
+
#if defined(HOST_ARCH_MIPS)
#include <asm/cachectl.h> /* NOLINT */
#include <sys/syscall.h> /* NOLINT */
#include <unistd.h> /* NOLINT */
#endif
-#include "vm/cpu.h"
-
namespace dart {
void CPU::FlushICache(uword start, uword size) {
@@ -37,6 +39,31 @@
"mips";
}
+
+char CPUFeatures::hardware_[HARDWARE_LEN] = {0};
+#if defined(DEBUG)
+bool CPUFeatures::initialized_ = false;
+#endif
+
+
+char* CPUFeatures::hardware() {
+ DEBUG_ASSERT(initialized_);
+ return hardware_;
+}
+
+
+void CPUFeatures::InitOnce() {
+ CpuInfo::Read();
+ CpuInfo::GetCpuModel(hardware_, HARDWARE_LEN);
+#if !defined(USING_SIMULATOR)
+ // Has a floating point unit.
+ ASSERT(CpuInfo::FieldContains("cpu model", "FPU"));
+#endif // defined(USING_SIMULATOR)
+#if defined(DEBUG)
+ initialized_ = true;
+#endif
+}
+
} // namespace dart
#endif // defined TARGET_ARCH_MIPS

Powered by Google App Engine
This is Rietveld 408576698