Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(45)

Issue 1207183003: Update public/platform/DEPS to forbidden public/web and web. (Closed)

Created:
4 years, 10 months ago by tasak
Modified:
4 years, 10 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, dglazkov+blink, ortuno
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update public/platform/DEPS to forbidden public/web and web. BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197896

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M public/platform/DEPS View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 12 (4 generated)
tasak
Would you review this CL?
4 years, 10 months ago (2015-06-25 06:57:03 UTC) #2
haraken
LGTM
4 years, 10 months ago (2015-06-25 06:57:44 UTC) #3
tkent
lgtm https://codereview.chromium.org/1207183003/diff/1/public/platform/DEPS File public/platform/DEPS (right): https://codereview.chromium.org/1207183003/diff/1/public/platform/DEPS#newcode6 public/platform/DEPS:6: "+platform/weborigin", Is this line necessary?
4 years, 10 months ago (2015-06-25 07:01:21 UTC) #4
tasak
Thank you for review. https://codereview.chromium.org/1207183003/diff/1/public/platform/DEPS File public/platform/DEPS (right): https://codereview.chromium.org/1207183003/diff/1/public/platform/DEPS#newcode6 public/platform/DEPS:6: "+platform/weborigin", On 2015/06/25 07:01:21, tkent ...
4 years, 10 months ago (2015-06-25 07:05:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207183003/1
4 years, 10 months ago (2015-06-25 09:01:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/68260)
4 years, 10 months ago (2015-06-25 13:01:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207183003/1
4 years, 10 months ago (2015-06-26 05:56:17 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-26 07:20:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197896

Powered by Google App Engine
This is Rietveld 408576698