Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 1207163002: Fix up HotwordServiceTest on Chrome-branded builds. (Closed)

Created:
5 years, 6 months ago by Matt Giuca
Modified:
5 years, 6 months ago
Reviewers:
kcarattini, Nico
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, rlp+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@hotword-disable-default
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix up HotwordServiceTest on Chrome-branded builds. The ENABLE_HOTWORDING flag is not available in hotword_service_unittest.cc, so all tests were assuming hotwording was disabled (since r333548). This has been failing on Official builders since r335874. Since it's hard to resolve this in a simple way (we want to merge these changes), just disabling the tests is the cleanest option for now. BUG=503963 Committed: https://crrev.com/8ef0bc35b1594ad013dc2ae1d6893e0091919271 Cr-Commit-Position: refs/heads/master@{#336091}

Patch Set 1 #

Patch Set 2 : Update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/search/hotword_service_unittest.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Matt Giuca
5 years, 6 months ago (2015-06-25 03:09:12 UTC) #2
Nico
lgtm
5 years, 6 months ago (2015-06-25 03:38:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207163002/20001
5 years, 6 months ago (2015-06-25 03:38:20 UTC) #6
kcarattini
lgtm
5 years, 6 months ago (2015-06-25 04:15:44 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-25 04:19:25 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 04:20:27 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ef0bc35b1594ad013dc2ae1d6893e0091919271
Cr-Commit-Position: refs/heads/master@{#336091}

Powered by Google App Engine
This is Rietveld 408576698