Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1207113002: Extract some WebViewTest to separate test suites. (Closed)

Created:
5 years, 5 months ago by lazyboy
Modified:
5 years, 5 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract some WebViewTest to separate test suites. Each of these test suites represents a feature that currently to not work with OOPIF based <webview>. So these will be disabled initially in site isolation FYI bots. The plan is to gradually fix these features and turn them on in site isolation bots. TBR=jam@chromium.org for testing/buildbot/chromium.fyi.json BUG=330264 Committed: https://crrev.com/8db99d435fbc0c2c0a0b3c6aac8d03913c85daa1 Cr-Commit-Position: refs/heads/master@{#336052}

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -24 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 16 chunks +36 lines, -22 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
lazyboy
5 years, 5 months ago (2015-06-24 21:56:22 UTC) #2
Fady Samuel
lgtm
5 years, 5 months ago (2015-06-24 22:55:34 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207113002/20001
5 years, 5 months ago (2015-06-24 23:03:43 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-24 23:46:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207113002/20001
5 years, 5 months ago (2015-06-25 00:16:58 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-06-25 00:22:20 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-06-25 00:23:20 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8db99d435fbc0c2c0a0b3c6aac8d03913c85daa1
Cr-Commit-Position: refs/heads/master@{#336052}

Powered by Google App Engine
This is Rietveld 408576698