Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1207103002: Update WebLocalFrameImpl and RotationViewportAnchor for root layer scrolling. (Closed)

Created:
5 years, 6 months ago by skobes
Modified:
5 years, 6 months ago
Reviewers:
bokan
CC:
blink-reviews, szager1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update WebLocalFrameImpl and RotationViewportAnchor for root layer scrolling. These classes now use the layout viewport ScrollableArea instead of FrameView. BUG=490942 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197820

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -27 lines) Patch
M Source/web/RotationViewportAnchor.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebLocalFrameImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +18 lines, -14 lines 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 6 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
skobes
5 years, 6 months ago (2015-06-24 23:20:58 UTC) #4
bokan
lgtm
5 years, 6 months ago (2015-06-25 13:20:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207103002/40001
5 years, 6 months ago (2015-06-25 13:20:45 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 13:24:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197820

Powered by Google App Engine
This is Rietveld 408576698