Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 12071002: Allow inlining of multiple closures from shared function. (Closed)

Created:
7 years, 11 months ago by Michael Starzinger
Modified:
7 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Allow inlining of multiple closures from shared function. This allows Crankshaft to allow inlining of multiple different closures that were all derived from the same shared function info. This pattern appears when libraries provide generic closures that are used over and over again at different call-sites. R=jkummerow@chromium.org TEST=mjsunit/compiler/inline-closures Committed: http://code.google.com/p/v8/source/detail?r=13522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M src/hydrogen.cc View 3 chunks +2 lines, -3 lines 0 comments Download
A + test/mjsunit/compiler/inline-closures.js View 1 chunk +17 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
7 years, 11 months ago (2013-01-25 16:36:04 UTC) #1
Jakob Kummerow
7 years, 11 months ago (2013-01-25 16:38:43 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698