Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: ppapi/cpp/video_decoder.h

Issue 1207043002: Introduce a client minimum picture pool size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/c/ppb_video_decoder.h ('k') | ppapi/cpp/video_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/cpp/video_decoder.h
diff --git a/ppapi/cpp/video_decoder.h b/ppapi/cpp/video_decoder.h
index 60be572cf89c0c2fbfd18401714587e326b97a02..98a84ce647adf15792b8ca5b7f120f8571363d0c 100644
--- a/ppapi/cpp/video_decoder.h
+++ b/ppapi/cpp/video_decoder.h
@@ -77,6 +77,34 @@ class VideoDecoder : public Resource {
PP_HardwareAcceleration acceleration,
const CompletionCallback& callback);
bbudge 2015/06/25 01:20:53 We don't usually support older interface versions
lpique 2015/06/25 22:21:18 Done.
+ /// Initializes a video decoder resource. This should be called after Create()
+ /// and before any other functions.
+ ///
+ /// @param[in] graphics3d_context A <code>PPB_Graphics3D</code> resource to
+ /// use during decoding.
+ /// @param[in] profile A <code>PP_VideoProfile</code> specifying the video
+ /// codec profile.
+ /// @param[in] acceleration A <code>PP_HardwareAcceleration</code> specifying
+ /// whether to use a hardware accelerated or a software implementation.
+ /// @param[in] min_picture_count A count of pictures the plugin would like to
+ /// have in flight. This is effectively the number of times the plugin can
+ /// call GetPicture() and get a decoded frame without calling
+ /// RecyclePicture(). The decoder has its own internal minimum count, and will
+ /// take the larger of its internal and this value. A client that doesn't care
+ /// can therefore just pass in zero for this argument.
+ /// @param[in] callback A <code>PP_CompletionCallback</code> to be called upon
+ /// completion.
+ ///
+ /// @return An int32_t containing an error code from <code>pp_errors.h</code>.
+ /// Returns PP_ERROR_NOTSUPPORTED if video decoding is not available, or the
+ /// requested profile is not supported. In this case, the client may call
+ /// Initialize() again with different parameters to find a good configuration.
+ int32_t Initialize(const Graphics3D& graphics3d_context,
+ PP_VideoProfile profile,
+ PP_HardwareAcceleration acceleration,
+ uint32_t min_picture_count,
+ const CompletionCallback& callback);
+
/// Decodes a bitstream buffer. Copies |size| bytes of data from the plugin's
/// |buffer|. The plugin should wait until the decoder signals completion by
/// returning PP_OK or by running |callback| before calling Decode() again.
« no previous file with comments | « ppapi/c/ppb_video_decoder.h ('k') | ppapi/cpp/video_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698