Introduce a client minimum picture pool size

remoting/client/plugin/pepper_video_renderer_3d.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/plugin/pepper_video_renderer_3d.h"
 
 #include <math.h>
 
 #include "base/callback_helpers.h"
 #include "base/stl_util.h"
@@ skipping 154 matching lines @@
       video_profile = PP_VIDEOPROFILE_VP8_ANY;
       break;
     case protocol::ChannelConfig::CODEC_VP9:
       video_profile = PP_VIDEOPROFILE_VP9_ANY;
       break;
     default:
       NOTREACHED();
   }
   int32_t result = video_decoder_.Initialize(
       graphics_, video_profile, PP_HARDWAREACCELERATION_WITHFALLBACK,
+      kMinimumPictureCount,

[Sergey Ulanov, 2015/08/11 23:10:20]

Actually looking at the implementation it appears that this call will fail in
older versions of browser that don't support the new version of the interface.
So maybe detect here if the new interface is supported and pass 0 otherwise?

[lpique, 2015/08/12 01:08:50]

Yikes. I didn't even think about this being a plugin when responding to your
last feedback.

I'm going to have to deal with the fact that the new version of the API is
Dev-channel only as well. Perhaps it is better to use zero for now, and leave a
TODO behind to change it to three once the API is promoted out of dev.

       callback_factory_.NewCallback(&PepperVideoRenderer3D::OnInitialized));
   CHECK_EQ(result, PP_OK_COMPLETIONPENDING)
       << "video_decoder_.Initialize() returned " << result;
 }
 
 ChromotingStats* PepperVideoRenderer3D::GetStats() {
   return &stats_;
 }
 
 protocol::VideoStub* PepperVideoRenderer3D::GetVideoStub() {
@@ skipping 345 matching lines @@
   gles2_if_->AttachShader(graphics_.pp_resource(), shader_program_, shader);
   gles2_if_->DeleteShader(graphics_.pp_resource(), shader);
 }
 
 void PepperVideoRenderer3D::CheckGLError() {
   GLenum error = gles2_if_->GetError(graphics_.pp_resource());
   CHECK_EQ(error, static_cast<GLenum>(GL_NO_ERROR)) << "GL error: " << error;
 }
 
 }  // namespace remoting