Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1207013002: JSON.stringify should use toString of replacer and not valueOf (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

JSON.stringify should use toString of replacer and not valueOf If the replacer array contains a number wrapper we should use the toString result and not valueOf. BUG=v8:4228 LOG=N R=adamk CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/6e6a1c8aee16cffdcbbf54f09b73b2b79b2ecedf Cr-Commit-Position: refs/heads/master@{#29270}

Patch Set 1 #

Patch Set 2 : Align better with spec algorithm #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -9 lines) Patch
M src/json.js View 1 1 chunk +11 lines, -9 lines 1 comment Download
A test/mjsunit/json-replacer-number-wrapper-tostring.js View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
arv (Not doing code reviews)
Align better with spec algorithm
5 years, 6 months ago (2015-06-24 20:56:42 UTC) #1
arv (Not doing code reviews)
PTAL https://codereview.chromium.org/1207013002/diff/20001/src/json.js File src/json.js (left): https://codereview.chromium.org/1207013002/diff/20001/src/json.js#oldcode223 src/json.js:223: // We cannot use true here because __proto__ ...
5 years, 6 months ago (2015-06-24 20:57:57 UTC) #2
adamk
lgtm
5 years, 6 months ago (2015-06-24 21:10:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207013002/20001
5 years, 6 months ago (2015-06-24 21:11:27 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-24 22:17:57 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 22:18:17 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6e6a1c8aee16cffdcbbf54f09b73b2b79b2ecedf
Cr-Commit-Position: refs/heads/master@{#29270}

Powered by Google App Engine
This is Rietveld 408576698