Fix- WebMediaPlayerAndroid::hasAudio() to query status of audio and return actual value

content/renderer/media/android/webmediaplayer_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/android/webmediaplayer_android.h"
 
 #include <limits>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 418 matching lines @@
   // We don't know whether the current media content has video unless
   // the player is prepared. If the player is not prepared, we fall back
   // to the mime-type. There may be no mime-type on a redirect URL.
   // In that case, we conservatively assume it contains video so that
   // enterfullscreen call will not fail.
   if (!url_.has_path())
     return false;
   std::string mime;
   if (!net::GetMimeTypeFromFile(base::FilePath(url_.path()), &mime))
     return true;
   return mime.find("audio/") == std::string::npos;

[vivekg, 2013/12/23 12:00:21]

Would it make sense to check for specific video mime-types specified in [1]/[2]
instead of checking for "audio" not being present? 

[1] http://en.wikipedia.org/wiki/Internet_media_type
[2]
https://code.google.com/p/chromium/codesearch#chromium/src/net/base/mime_util...

Can we have some sort of testing done for these features? Either a unit test or
layout test may be!... I am not sure about these though! :) 

 }
 
 bool WebMediaPlayerAndroid::hasAudio() const {
   // TODO(hclam): Query status of audio and return the actual value.
-  return true;
+  if (!url_.has_path())
+    return false;
+  std::string mime;
+  if (!net::GetMimeTypeFromFile(base::FilePath(url_.path()), &mime))
+    return true;
+  return mime.find("audio/") == std::string::npos;

[vivekg, 2013/12/23 11:51:12]

This change looks suspicious to me! We need to check for the audio mime type and
this check is opposite to that.

 }
 
 bool WebMediaPlayerAndroid::paused() const {
   return !is_playing_;
 }
 
 bool WebMediaPlayerAndroid::seeking() const {
   return seeking_;
 }
 
@@ skipping 990 matching lines @@
 
 void WebMediaPlayerAndroid::exitFullscreen() {
   manager_->ExitFullscreen(player_id_);
 }
 
 bool WebMediaPlayerAndroid::canEnterFullscreen() const {
   return manager_->CanEnterFullscreen(frame_);
 }
 
 }  // namespace content