Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10506)

Unified Diff: chrome/common/net/url_util_unittest.cc

Issue 12069004: google_apis: Move AppendQueryParameter() etc. from common/net/url_util.h to net/base/url_util.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/net/url_util_unittest.cc
diff --git a/chrome/common/net/url_util_unittest.cc b/chrome/common/net/url_util_unittest.cc
index 1d7fdda7d478ffd09399120e1f5dd1299d41b5be..c998b04c19e3555941ce814ecdefa4aecb764b21 100644
--- a/chrome/common/net/url_util_unittest.cc
+++ b/chrome/common/net/url_util_unittest.cc
@@ -9,77 +9,6 @@
namespace chrome_common_net {
-TEST(UrlUtilTest, AppendQueryParameter) {
- // Appending a name-value pair to a URL without a query component.
- EXPECT_EQ("http://example.com/path?name=value",
- AppendQueryParameter(GURL("http://example.com/path"),
- "name", "value").spec());
-
- // Appending a name-value pair to a URL with a query component.
- // The original component should be preserved, and the new pair should be
- // appended with '&'.
- EXPECT_EQ("http://example.com/path?existing=one&name=value",
- AppendQueryParameter(GURL("http://example.com/path?existing=one"),
- "name", "value").spec());
-
- // Appending a name-value pair with unsafe characters included. The
- // unsafe characters should be escaped.
- EXPECT_EQ("http://example.com/path?existing=one&na+me=v.alue%3D",
- AppendQueryParameter(GURL("http://example.com/path?existing=one"),
- "na me", "v.alue=").spec());
-
-}
-
-TEST(UrlUtilTest, AppendOrReplaceQueryParameter) {
- // Appending a name-value pair to a URL without a query component.
- EXPECT_EQ("http://example.com/path?name=value",
- AppendOrReplaceQueryParameter(GURL("http://example.com/path"),
- "name", "value").spec());
-
- // Appending a name-value pair to a URL with a query component.
- // The original component should be preserved, and the new pair should be
- // appended with '&'.
- EXPECT_EQ("http://example.com/path?existing=one&name=value",
- AppendOrReplaceQueryParameter(
- GURL("http://example.com/path?existing=one"),
- "name", "value").spec());
-
- // Appending a name-value pair with unsafe characters included. The
- // unsafe characters should be escaped.
- EXPECT_EQ("http://example.com/path?existing=one&na+me=v.alue%3D",
- AppendOrReplaceQueryParameter(
- GURL("http://example.com/path?existing=one"),
- "na me", "v.alue=").spec());
-
- // Replace value of an existing paramater.
- EXPECT_EQ("http://example.com/path?existing=one&name=new",
- AppendOrReplaceQueryParameter(
- GURL("http://example.com/path?existing=one&name=old"),
- "name", "new").spec());
-
- // Replace a name-value pair with unsafe characters included. The
- // unsafe characters should be escaped.
- EXPECT_EQ("http://example.com/path?na+me=n.ew%3D&existing=one",
- AppendOrReplaceQueryParameter(
- GURL("http://example.com/path?na+me=old&existing=one"),
- "na me", "n.ew=").spec());
-
- // Replace the value of first parameter with this name only.
- EXPECT_EQ("http://example.com/path?name=new&existing=one&name=old",
- AppendOrReplaceQueryParameter(
- GURL("http://example.com/path?name=old&existing=one&name=old"),
- "name", "new").spec());
-
- // Preserve the content of the original params regarless of our failure to
- // interpret them correctly.
- EXPECT_EQ("http://example.com/path?bar&name=new&left=&"
- "=right&=&&name=again",
- AppendOrReplaceQueryParameter(
- GURL("http://example.com/path?bar&name=old&left=&"
- "=right&=&&name=again"),
- "name", "new").spec());
-}
-
TEST(BrowserUrlUtilTest, GetValueForKeyInQuery) {
GURL url("http://example.com/path?name=value&boolParam&"
"url=http://test.com/q?n1%3Dv1%26n2");
@@ -99,4 +28,4 @@ TEST(BrowserUrlUtilTest, GetValueForKeyInQuery) {
EXPECT_EQ("http://test.com/q?n1=v1&n2", value);
}
-} // namespace chrome_common_net.
+} // namespace chrome_common_net

Powered by Google App Engine
This is Rietveld 408576698