google_apis: Move AppendQueryParameter() etc. from common/net/url_util.h to net/base/url_util.h

net/base/url_util_unittest.cc

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/common/net/url_util.h"
+#include "net/base/url_util.h"
 
 #include "googleurl/src/gurl.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
-namespace chrome_common_net {
+namespace net {
 

[mmenke, 2013/01/28 15:33:37]

While you're here, mind adding a nested anonymous namespace?

[tfarina, 2013/01/28 15:55:58]

Done.

 TEST(UrlUtilTest, AppendQueryParameter) {
   // Appending a name-value pair to a URL without a query component.
   EXPECT_EQ("http://example.com/path?name=value",
             AppendQueryParameter(GURL("http://example.com/path"),
                                  "name", "value").spec());
 
   // Appending a name-value pair to a URL with a query component.
   // The original component should be preserved, and the new pair should be
   // appended with '&'.
   EXPECT_EQ("http://example.com/path?existing=one&name=value",
@@ skipping 51 matching lines @@
   // Preserve the content of the original params regarless of our failure to
   // interpret them correctly.
   EXPECT_EQ("http://example.com/path?bar&name=new&left=&"
             "=right&=&&name=again",
       AppendOrReplaceQueryParameter(
           GURL("http://example.com/path?bar&name=old&left=&"
                 "=right&=&&name=again"),
           "name", "new").spec());
 }
 
-TEST(BrowserUrlUtilTest, GetValueForKeyInQuery) {
-  GURL url("http://example.com/path?name=value&boolParam&"
-           "url=http://test.com/q?n1%3Dv1%26n2");
-  std::string value;
-
-  // False when getting a non-existent query param.
-  EXPECT_FALSE(GetValueForKeyInQuery(url, "non-exist", &value));
-
-  // True when query param exist.
-  EXPECT_TRUE(GetValueForKeyInQuery(url, "name", &value));
-  EXPECT_EQ("value", value);
-
-  EXPECT_TRUE(GetValueForKeyInQuery(url, "boolParam", &value));
-  EXPECT_EQ("", value);
-
-  EXPECT_TRUE(GetValueForKeyInQuery(url, "url", &value));
-  EXPECT_EQ("http://test.com/q?n1=v1&n2", value);
-}
-
-}  // namespace chrome_common_net.
+}  // namespace net