Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2662)

Unified Diff: base/message_loop/message_loop.h

Issue 1206893003: base: Make it possible to replace the MessageLoop's task runner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change in media/blink/webmediaplayer_impl.cc is not needed Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_loop/bindable_single_thread_task_runner.h ('k') | base/message_loop/message_loop.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop/message_loop.h
diff --git a/base/message_loop/message_loop.h b/base/message_loop/message_loop.h
index 1b6d407241acf9114495af249ba8aeb5428fae22..3a3b657243c80bbd35f96466c7cd760d1d10694d 100644
--- a/base/message_loop/message_loop.h
+++ b/base/message_loop/message_loop.h
@@ -12,6 +12,7 @@
#include "base/basictypes.h"
#include "base/callback_forward.h"
#include "base/debug/task_annotator.h"
+#include "base/gtest_prod_util.h"
#include "base/location.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
@@ -37,6 +38,7 @@
namespace base {
+class BindableSingleThreadTaskRunner;
class HistogramBase;
class RunLoop;
class ThreadTaskRunnerHandle;
@@ -296,9 +298,17 @@ class BASE_EXPORT MessageLoop : public MessagePump::Delegate {
const std::string& thread_name() const { return thread_name_; }
// Gets the TaskRunner associated with this message loop.
- // TODO(skyostil): Change this to return a const reference to a refptr
- // once the internal type matches what is being returned (crbug.com/465354).
- scoped_refptr<SingleThreadTaskRunner> task_runner() { return task_runner_; }
+ scoped_refptr<SingleThreadTaskRunner> task_runner() {
+ return task_runner_;
+ }
+
+ // Sets a new TaskRunner for this message loop and returns the previous one.
+ // If the message loop was already bound to a thread, this function must be
+ // called on that thread and the task runner must also belong to that thread.
+ // Note that changing the task runner will also affect the
+ // ThreadTaskRunnerHandle for the target thread.
+ scoped_refptr<BindableSingleThreadTaskRunner> SwapTaskRunner(
+ scoped_refptr<BindableSingleThreadTaskRunner> task_runner);
// Enables or disables the recursive task processing. This happens in the case
// of recursive message loops. Some unwanted message loop may occurs when
@@ -401,6 +411,7 @@ class BASE_EXPORT MessageLoop : public MessagePump::Delegate {
friend class internal::IncomingTaskQueue;
friend class ScheduleWorkTest;
friend class Thread;
+ FRIEND_TEST_ALL_PREFIXES(MessageLoopTest, SwapTaskRunnerBeforeBinding);
using MessagePumpFactoryCallback = Callback<scoped_ptr<MessagePump>()>;
@@ -523,7 +534,7 @@ class BASE_EXPORT MessageLoop : public MessagePump::Delegate {
scoped_refptr<internal::IncomingTaskQueue> incoming_task_queue_;
// The task runner associated with this message loop.
- scoped_refptr<internal::MessageLoopTaskRunner> task_runner_;
+ scoped_refptr<BindableSingleThreadTaskRunner> task_runner_;
scoped_ptr<ThreadTaskRunnerHandle> thread_task_runner_handle_;
template <class T, class R> friend class base::subtle::DeleteHelperInternal;
« no previous file with comments | « base/message_loop/bindable_single_thread_task_runner.h ('k') | base/message_loop/message_loop.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698