Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1206893002: PPC: Use big-boy Types to annotate interface descriptor parameters (Closed)

Created:
5 years, 6 months ago by MTBrandyberry
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Use big-boy Types to annotate interface descriptor parameters Port c019d7f498ce6fbac6659924e20ddb6c59aebeb8 Original commit message: - Thread Type::FunctionType through stubs and the TF pipeline. - Augment Typer to decorate parameter nodes with types from a Type::FunctionType associated with interface descriptors. - Factor interface descriptors into platform-specific and platform-independent components so that all descriptors share a common Type::FunctionType for all platforms. R=danno@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/5989a374c95f9f138b4953e5f801c5d368acfe8a Cr-Commit-Position: refs/heads/master@{#29257}

Patch Set 1 #

Patch Set 2 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -128 lines) Patch
M src/ppc/interface-descriptors-ppc.cc View 1 5 chunks +90 lines, -128 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 6 months ago (2015-06-24 15:33:32 UTC) #1
dstence
lgtm
5 years, 6 months ago (2015-06-24 15:38:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206893002/20001
5 years, 6 months ago (2015-06-24 15:42:38 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-24 16:10:01 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 16:10:18 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5989a374c95f9f138b4953e5f801c5d368acfe8a
Cr-Commit-Position: refs/heads/master@{#29257}

Powered by Google App Engine
This is Rietveld 408576698