Source/platform/fonts/Character.h - Issue 1206883002: Fix default text orientation that do not conform Unicode Technical Report #50

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/Character.h

Issue 1206883002: Fix default text orientation that do not conform Unicode Technical Report #50 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/writing-mode/text-orientation-mongolian-phagspa-expected.txt ('k') | Source/platform/fonts/Character.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/fonts/Character.h

diff --git a/Source/platform/fonts/Character.h b/Source/platform/fonts/Character.h

index eeffbc68ee348496f5b436a679f83769dea155a9..c06eeb364bf8bada34fee25c8955872487501429 100644

--- a/Source/platform/fonts/Character.h

+++ b/Source/platform/fonts/Character.h

@@ -65,7 +65,7 @@ public:

static unsigned expansionOpportunityCount(const LChar*, size_t length, TextDirection, bool& isAfterExpansion, const TextJustify);

static unsigned expansionOpportunityCount(const UChar*, size_t length, TextDirection, bool& isAfterExpansion, const TextJustify);

- static bool shouldIgnoreRotation(UChar32 character);

+ static bool isUprightInMixedVertical(UChar32 character);

static bool treatAsSpace(UChar c)

{