Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(139)

Issue 1206883002: Fix default text orientation that do not conform Unicode Technical Report #50 (Closed)

Created:
4 years, 10 months ago by kojii
Modified:
4 years, 10 months ago
Reviewers:
eae
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix default text orientation that do not conform Unicode Technical Report #50 This patch fixes the default orientation of glyphs in vertical flow. In vertical flow, when the author does not specify the orientation of glyphs using the text-orientation property[1], the spec defines[2] that UA must typeset by following UTR#50[3]. Currently, Blink honors UTR#50 only for non-CJK code points, and some of the non-CJK have incorrect orientation, resulting 462 failures in total. This patch fixes both some CJK characters that must rotate, and incorrect orientation of non-CJK characters. Mongolian/Phags-Pa specific orientation test was removed as these scripts are now covered by imported CSS WG tests. One code point in the imported tests still fail: text-orientation-script-001e.html This needs further analysis, which is deferred from this patch. [1] http://dev.w3.org/csswg/css-writing-modes-3/#text-orientation [2] http://dev.w3.org/csswg/css-writing-modes-3/#vertical-orientations [3] http://www.unicode.org/reports/tr50/ BUG=503979 TEST=imported/csswg-test/css-writing-modes-3/text-orientation-script-001[a-o].html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197786

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -227 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +8 lines, -9 lines 0 comments Download
D LayoutTests/fast/writing-mode/text-orientation-mongolian-phagspa.html View 1 1 chunk +0 lines, -123 lines 0 comments Download
D LayoutTests/fast/writing-mode/text-orientation-mongolian-phagspa-expected.txt View 1 1 chunk +0 lines, -17 lines 0 comments Download
M Source/platform/fonts/Character.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/Character.cpp View 1 chunk +120 lines, -68 lines 0 comments Download
M Source/platform/fonts/Font.cpp View 1 4 chunks +10 lines, -9 lines 0 comments Download
M Source/platform/fonts/FontDescription.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/fonts/FontOrientation.h View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kojii
PTAL.
4 years, 10 months ago (2015-06-24 17:57:21 UTC) #2
eae
LGTM
4 years, 10 months ago (2015-06-24 17:59:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206883002/20001
4 years, 10 months ago (2015-06-24 23:50:18 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 23:53:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197786

Powered by Google App Engine
This is Rietveld 408576698