Source/web/WebDevToolsAgentImpl.cpp - Issue 1206833003: Devtools[LayoutEditor]: Pass data about property change from InspectorOverlayPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebDevToolsAgentImpl.cpp

Issue 1206833003: Devtools[LayoutEditor]: Pass data about property change from InspectorOverlayPage (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix empty line Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebDevToolsAgentImpl.cpp

diff --git a/Source/web/WebDevToolsAgentImpl.cpp b/Source/web/WebDevToolsAgentImpl.cpp

index ec6e783c20b684303dc7e686d0601f96287005fc..4b83a262c7eacebb65998810dbefcab32c46c982 100644

--- a/Source/web/WebDevToolsAgentImpl.cpp

+++ b/Source/web/WebDevToolsAgentImpl.cpp

@@ -425,6 +425,7 @@ void WebDevToolsAgentImpl::willBeDestroyed()

detach();

m_injectedScriptManager->disconnect();

+ m_overlay->setCSSAgent(nullptr);

dgozman 2015/06/25 12:31:00 Let's clear on detach.

sergeyv 2015/06/25 12:54:31 Done.

m_agents.discardAgents();

m_instrumentingAgents->reset();

}

@@ -444,6 +445,7 @@ void WebDevToolsAgentImpl::initializeDeferredAgents()

OwnPtrWillBeRawPtr<InspectorCSSAgent> cssAgentPtr(InspectorCSSAgent::create(m_domAgent, m_pageAgent, m_resourceAgent));

m_cssAgent = cssAgentPtr.get();

m_agents.append(cssAgentPtr.release());

+ m_overlay->setCSSAgent(m_cssAgent.get());

dgozman 2015/06/25 12:31:00 Let's set on attach.

sergeyv 2015/06/25 12:54:31 Done.

m_agents.append(InspectorAnimationAgent::create(m_pageAgent, m_domAgent));

« Source/web/InspectorOverlayImpl.cpp ('K') | « Source/web/InspectorOverlayImpl.cpp ('k') | no next file » | no next file with comments »