Devtools[LayoutEditor]: Pass data about property change from InspectorOverlayPage

Source/core/inspector/LayoutEditor.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/inspector/LayoutEditor.h"
 
-#include "core/dom/Node.h"
+#include "core/css/CSSComputedStyleDeclaration.h"
+#include "core/css/CSSPrimitiveValue.h"
 #include "core/frame/FrameView.h"
+#include "core/inspector/InspectorCSSAgent.h"
 #include "core/layout/LayoutBox.h"
 #include "core/layout/LayoutInline.h"
 #include "core/layout/LayoutObject.h"
 #include "platform/JSONValues.h"
 
-
 namespace blink {
 
 namespace {
 
 PassRefPtr<JSONObject> createAnchor(float x, float y, const String& propertyName, FloatPoint deltaVector)
 {
     RefPtr<JSONObject> object = JSONObject::create();
     object->setNumber("x", x);
     object->setNumber("y", y);
     object->setString("propertyName", propertyName);
@@ skipping 17 matching lines @@
 FloatPoint orthogonalVector(FloatPoint from, FloatPoint to, FloatPoint defaultVector)
 {
     if (from == to)
         return defaultVector;
 
     return FloatPoint(to.y() - from.y(), from.x() - to.x());
 }
 
 } // namespace
 
-LayoutEditor::LayoutEditor(Node* node)
-    : m_node(node)
+LayoutEditor::LayoutEditor(InspectorCSSAgent* cssAgent)
+    : m_node(nullptr)
+    , m_cssAgent(cssAgent)
+    , m_changingProperty(CSSPropertyInvalid)
+    , m_propertyInitialValue(0)
 {
 }
 
+void LayoutEditor::setNode(Node* node)
+{
+    m_node = node;
+    m_changingProperty = CSSPropertyInvalid;
+    m_propertyInitialValue = 0;
+}
+
 PassRefPtr<JSONObject> LayoutEditor::buildJSONInfo() const
 {
+    if (!m_node)
+        return nullptr;
+
     LayoutObject* layoutObject = m_node->layoutObject();
 
     if (!layoutObject)
         return nullptr;
 
     FrameView* containingView = layoutObject->frameView();
     if (!containingView)
         return nullptr;
     if (!layoutObject->isBox() && !layoutObject->isLayoutInline())
         return nullptr;
@@ skipping 28 matching lines @@
     float yRight = (padding.p2().y() + padding.p3().y()) / 2;
     FloatPoint orthoRight = orthogonalVector(padding.p2(), padding.p3(), FloatPoint(1, 0));
 
     RefPtr<JSONObject> object = JSONObject::create();
     RefPtr<JSONArray> anchors = JSONArray::create();
     anchors->pushObject(createAnchor(xLeft, yLeft, "padding-left", orthoLeft));
     anchors->pushObject(createAnchor(xRight, yRight, "padding-right", orthoRight));
     object->setArray("anchors", anchors.release());
 
     return object.release();
+}
 
+void LayoutEditor::overlayStartedPropertyChange(const String& anchorName)
+{
+    m_changingProperty = cssPropertyID(anchorName);
+    if (!m_node || !m_changingProperty)

[dgozman, 2015/06/25 12:30:59]

Let's explicitly compare with CSSPropertyInvalid.

[sergeyv, 2015/06/25 12:54:31]

In CSSComputedStyleDeclaration.cpp they do like this

+        return;
+
+    RefPtrWillBeRawPtr<CSSComputedStyleDeclaration> computedStyleInfo = CSSComputedStyleDeclaration::create(m_node, true);
+    RefPtrWillBeRawPtr<CSSValue> cssValue = computedStyleInfo->getPropertyCSSValue(m_changingProperty);
+    if (!cssValue->isPrimitiveValue())
+        return;

[dgozman, 2015/06/25 12:30:59]

m_changingProperty = CSSPropertyInvalid;

[sergeyv, 2015/06/25 12:54:31]

Done.

+
+    m_propertyInitialValue = toCSSPrimitiveValue(cssValue.get())->getFloatValue();
+}
+
+void LayoutEditor::overlayPropertyChanged(float cssDelta)
+{
+    if (m_changingProperty)

[dgozman, 2015/06/25 12:31:00]

Let's explicitly compare with CSSPropertyInvalid.

[sergeyv, 2015/06/25 12:54:31]

ditto

+        m_cssAgent->updateCSSProperty(m_node.get(), m_changingProperty, cssDelta + m_propertyInitialValue);
+}
+
+void LayoutEditor::overlayEndedPropertyChange()
+{
+    m_changingProperty = CSSPropertyInvalid;
+    m_propertyInitialValue = 0;
 }
 
 } // namespace blink