Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(135)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1206833003: Devtools[LayoutEditor]: Pass data about property change from InspectorOverlayPage (Closed)

Created:
4 years, 10 months ago by sergeyv
Modified:
4 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, vivekg, vivekg_samsung, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools[LayoutEditor]: Pass data about property change from InspectorOverlayPage BUG=501896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197830

Patch Set 1 #

Patch Set 2 : #

Total comments: 26

Patch Set 3 : Address comments #

Patch Set 4 : Fix empty line #

Total comments: 18

Patch Set 5 : Address comments #

Total comments: 2

Patch Set 6 : #

Total comments: 4

Patch Set 7 : Address pfeldman's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -31 lines) Patch
M Source/core/inspector/InspectorCSSAgent.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.h View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorOverlayHost.h View 1 2 1 chunk +18 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorOverlayHost.cpp View 1 2 2 chunks +26 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorOverlayHost.idl View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorOverlayPage.html View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
M Source/core/inspector/LayoutEditor.h View 1 2 1 chunk +20 lines, -5 lines 0 comments Download
M Source/core/inspector/LayoutEditor.cpp View 1 2 3 4 3 chunks +45 lines, -4 lines 0 comments Download
M Source/web/InspectorOverlayImpl.h View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 1 2 3 4 5 6 8 chunks +19 lines, -10 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 2 3 4 5 6 3 chunks +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1153503010 Patch 1

Messages

Total messages: 24 (9 generated)
sergeyv
4 years, 10 months ago (2015-06-24 16:52:38 UTC) #2
dgozman
We should reverse the dependency CSSAgent->LayoutEditor.
4 years, 10 months ago (2015-06-24 17:18:05 UTC) #3
dgozman
Almost there. https://codereview.chromium.org/1206833003/diff/60001/Source/core/inspector/InspectorCSSAgent.cpp File Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/1206833003/diff/60001/Source/core/inspector/InspectorCSSAgent.cpp#newcode57 Source/core/inspector/InspectorCSSAgent.cpp:57: #include "core/inspector/InspectorOverlay.h" Not used. https://codereview.chromium.org/1206833003/diff/60001/Source/core/inspector/InspectorCSSAgent.h File Source/core/inspector/InspectorCSSAgent.h ...
4 years, 10 months ago (2015-06-25 10:10:39 UTC) #7
sergeyv
https://codereview.chromium.org/1206833003/diff/60001/Source/core/inspector/InspectorCSSAgent.cpp File Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/1206833003/diff/60001/Source/core/inspector/InspectorCSSAgent.cpp#newcode57 Source/core/inspector/InspectorCSSAgent.cpp:57: #include "core/inspector/InspectorOverlay.h" On 2015/06/25 10:10:38, dgozman wrote: > Not ...
4 years, 10 months ago (2015-06-25 12:19:17 UTC) #8
dgozman
https://codereview.chromium.org/1206833003/diff/100001/Source/core/inspector/InspectorCSSAgent.h File Source/core/inspector/InspectorCSSAgent.h (right): https://codereview.chromium.org/1206833003/diff/100001/Source/core/inspector/InspectorCSSAgent.h#newcode116 Source/core/inspector/InspectorCSSAgent.h:116: void updateCSSProperty(Node*, CSSPropertyID, float); setCSSPropertyValue? https://codereview.chromium.org/1206833003/diff/100001/Source/core/inspector/InspectorOverlayPage.html File Source/core/inspector/InspectorOverlayPage.html (right): ...
4 years, 10 months ago (2015-06-25 12:31:00 UTC) #9
sergeyv
https://codereview.chromium.org/1206833003/diff/100001/Source/core/inspector/InspectorCSSAgent.h File Source/core/inspector/InspectorCSSAgent.h (right): https://codereview.chromium.org/1206833003/diff/100001/Source/core/inspector/InspectorCSSAgent.h#newcode116 Source/core/inspector/InspectorCSSAgent.h:116: void updateCSSProperty(Node*, CSSPropertyID, float); On 2015/06/25 12:30:59, dgozman wrote: ...
4 years, 10 months ago (2015-06-25 12:54:31 UTC) #10
dgozman
lgtm https://codereview.chromium.org/1206833003/diff/120001/Source/web/WebDevToolsAgentImpl.cpp File Source/web/WebDevToolsAgentImpl.cpp (right): https://codereview.chromium.org/1206833003/diff/120001/Source/web/WebDevToolsAgentImpl.cpp#newcode539 Source/web/WebDevToolsAgentImpl.cpp:539: m_overlay->setCSSAgent(nullptr); Let's do this before instrumentation calls.
4 years, 10 months ago (2015-06-25 12:57:57 UTC) #11
sergeyv
https://codereview.chromium.org/1206833003/diff/120001/Source/web/WebDevToolsAgentImpl.cpp File Source/web/WebDevToolsAgentImpl.cpp (right): https://codereview.chromium.org/1206833003/diff/120001/Source/web/WebDevToolsAgentImpl.cpp#newcode539 Source/web/WebDevToolsAgentImpl.cpp:539: m_overlay->setCSSAgent(nullptr); On 2015/06/25 12:57:56, dgozman wrote: > Let's do ...
4 years, 10 months ago (2015-06-25 13:01:41 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206833003/140001
4 years, 10 months ago (2015-06-25 13:02:13 UTC) #15
pfeldman
https://codereview.chromium.org/1206833003/diff/140001/Source/web/InspectorOverlayImpl.cpp File Source/web/InspectorOverlayImpl.cpp (right): https://codereview.chromium.org/1206833003/diff/140001/Source/web/InspectorOverlayImpl.cpp#newcode492 Source/web/InspectorOverlayImpl.cpp:492: m_layoutEditor = LayoutEditor::create(cssAgent); Or maybe even make embedder instantiate ...
4 years, 10 months ago (2015-06-25 13:08:38 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-25 13:51:47 UTC) #18
sergeyv
https://codereview.chromium.org/1206833003/diff/140001/Source/web/InspectorOverlayImpl.cpp File Source/web/InspectorOverlayImpl.cpp (right): https://codereview.chromium.org/1206833003/diff/140001/Source/web/InspectorOverlayImpl.cpp#newcode492 Source/web/InspectorOverlayImpl.cpp:492: m_layoutEditor = LayoutEditor::create(cssAgent); On 2015/06/25 13:08:37, pfeldman wrote: > ...
4 years, 10 months ago (2015-06-25 14:46:11 UTC) #19
pfeldman
lgtm
4 years, 10 months ago (2015-06-25 14:49:00 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206833003/160001
4 years, 10 months ago (2015-06-25 14:49:43 UTC) #23
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 16:11:21 UTC) #24
Message was sent while issue was closed. 
Committed patchset #7 (id:160001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197830

Powered by Google App Engine
This is Rietveld 408576698