Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 120683002: Make `String.prototype.{starts,ends}With` throw when passing a regular expression (Closed)

Created:
7 years ago by mathias
Modified:
6 years, 10 months ago
CC:
v8-dev
Base URL:
git@github.com:v8/v8.git@master
Visibility:
Public.

Description

Make `String.prototype.{starts,ends}With` throw when passing a regular expression Contributed by Mathias Bynens <mathiasb@opera.com>;. TEST=mjsunit/harmony BUG=v8:3070 LOG=Y R=arv@chromium.org, ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18870

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adhere to a 80-character-per-line limit #

Patch Set 3 : Use the new `CHECK_OBJECT_COERCIBLE` macro #

Unified diffs Side-by-side diffs Delta from patch set Stats (+570 lines, -25 lines) Patch
M src/harmony-string.js View 1 2 5 chunks +19 lines, -19 lines 0 comments Download
M src/messages.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/harmony/string-endswith.js View 1 2 3 chunks +279 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/string-startswith.js View 1 2 3 chunks +271 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mathias
7 years ago (2013-12-23 07:38:01 UTC) #1
Yang
https://codereview.chromium.org/120683002/diff/1/test/mjsunit/harmony/string-endswith.js File test/mjsunit/harmony/string-endswith.js (right): https://codereview.chromium.org/120683002/diff/1/test/mjsunit/harmony/string-endswith.js#newcode324 test/mjsunit/harmony/string-endswith.js:324: assertThrows(function() { String.prototype.endsWith.call(undefined); }, TypeError); We try to adhere ...
7 years ago (2013-12-23 09:56:06 UTC) #2
mathias
On 2013/12/23 09:56:06, Yang wrote: > We try to adhere to a 80-character-per-line limit when ...
7 years ago (2013-12-23 12:21:05 UTC) #3
arv (Not doing code reviews)
LGTM but Yang has the final word here.
6 years, 11 months ago (2014-01-06 15:44:20 UTC) #4
Igor Sheludko
lgtm (Yang is not available now).
6 years, 11 months ago (2014-01-09 11:32:12 UTC) #5
mathias
Rebased and updated to use the new `CHECK_OBJECT_COERCIBLE` macro.
6 years, 11 months ago (2014-01-27 10:24:13 UTC) #6
Igor Sheludko
6 years, 10 months ago (2014-01-28 10:31:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r18870 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698