[x64] Fix instruction selection for Word64Equal(Word64And, 0).

[x64] Fix instruction selection for Word64Equal(Word64And, 0).

This fixes a slight inconsistency in the InstructionSelector that
basically disabled the optimization for things like ObjectIsSmi.

R=jarin@chromium.org

Committed: https://crrev.com/7a675e0e3be0fe1415c8243841fcbdff704dc32a
Cr-Commit-Position: refs/heads/master@{#29250}

[Benedikt Meurer, 2015-06-24 07:11:18]

Hey Jaro,

Trivial fix to make %_IsSmi fast on x64. Please take a look.

Thanks,
Benedikt

[Jarin, 2015-06-24 07:35:59]

lgtm.

https://codereview.chromium.org/1206773002/diff/1/src/compiler/x64/instructio...
File src/compiler/x64/instruction-selector-x64.cc (right):

https://codereview.chromium.org/1206773002/diff/1/src/compiler/x64/instructio...
src/compiler/x64/instruction-selector-x64.cc:1322: Node* const value =
m.left().node();
Could you avoid shadowing the 'user' and 'value' variables from above?

[Benedikt Meurer, 2015-06-24 07:38:18]

https://codereview.chromium.org/1206773002/diff/1/src/compiler/x64/instructio...
File src/compiler/x64/instruction-selector-x64.cc (right):

https://codereview.chromium.org/1206773002/diff/1/src/compiler/x64/instructio...
src/compiler/x64/instruction-selector-x64.cc:1322: Node* const value =
m.left().node();
On 2015/06/24 07:35:59, jarin wrote:
> Could you avoid shadowing the 'user' and 'value' variables from above?

Done.

[Benedikt Meurer, 2015-06-24 07:38:21]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-06-24 07:38:22]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/1206773002/#ps20001
(title: "Avoid shadowing.")

[commit-bot: I haz the power, 2015-06-24 07:38:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1206773002/20001

[commit-bot: I haz the power, 2015-06-24 07:58:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-24 07:58:39]

Exceeded global retry quota

[Benedikt Meurer, 2015-06-24 08:19:07]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-06-24 08:19:07]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/1206773002/#ps40001
(title: "Better fix.")

[commit-bot: I haz the power, 2015-06-24 08:19:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1206773002/40001

[Benedikt Meurer, 2015-06-24 08:19:51]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2015-06-24 08:44:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-24 08:44:10]

Exceeded global retry quota

[Benedikt Meurer, 2015-06-24 09:13:38]

Patchset #2 (id:40001) has been deleted

[Benedikt Meurer, 2015-06-24 09:13:42]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-06-24 09:13:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1206773002/1

[commit-bot: I haz the power, 2015-06-24 09:15:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-24 09:15:45]

Patchset 1 (id:??) landed as
https://crrev.com/7a675e0e3be0fe1415c8243841fcbdff704dc32a
Cr-Commit-Position: refs/heads/master@{#29250}