Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Side by Side Diff: sky/engine/tonic/dart_class_library.cc

Issue 1206763002: Really remove config.h (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/tonic/dart_builtin.cc ('k') | sky/engine/tonic/dart_class_provider.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sky/engine/config.h"
6 #include "sky/engine/tonic/dart_class_library.h" 5 #include "sky/engine/tonic/dart_class_library.h"
7 6
8 #include "base/logging.h" 7 #include "base/logging.h"
9 #include "sky/engine/tonic/dart_wrapper_info.h" 8 #include "sky/engine/tonic/dart_wrapper_info.h"
10 9
11 namespace blink { 10 namespace blink {
12 11
13 DartClassLibrary::DartClassLibrary() : provider_(nullptr) { 12 DartClassLibrary::DartClassLibrary() : provider_(nullptr) {
14 } 13 }
15 14
16 DartClassLibrary::~DartClassLibrary() { 15 DartClassLibrary::~DartClassLibrary() {
17 // Note that we don't need to delete these persistent handles because this 16 // Note that we don't need to delete these persistent handles because this
18 // object lives as long as the isolate. The handles will get deleted when the 17 // object lives as long as the isolate. The handles will get deleted when the
19 // isolate dies. 18 // isolate dies.
20 } 19 }
21 20
22 Dart_PersistentHandle DartClassLibrary::GetClass(const DartWrapperInfo& info) { 21 Dart_PersistentHandle DartClassLibrary::GetClass(const DartWrapperInfo& info) {
23 DCHECK(provider_); 22 DCHECK(provider_);
24 23
25 const auto& result = cache_.add(&info, nullptr); 24 const auto& result = cache_.add(&info, nullptr);
26 if (!result.isNewEntry) 25 if (!result.isNewEntry)
27 return result.storedValue->value; 26 return result.storedValue->value;
28 27
29 Dart_Handle class_handle = provider_->GetClassByName(info.interface_name); 28 Dart_Handle class_handle = provider_->GetClassByName(info.interface_name);
30 result.storedValue->value = Dart_NewPersistentHandle(class_handle); 29 result.storedValue->value = Dart_NewPersistentHandle(class_handle);
31 return result.storedValue->value; 30 return result.storedValue->value;
32 } 31 }
33 32
34 } // namespace blink 33 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/tonic/dart_builtin.cc ('k') | sky/engine/tonic/dart_class_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698