Add a TestRenderFrame to use in RenderViewTests

Add a TestRenderFrame to use in RenderViewTests

This CL adds a TestRenderFrame to use in RenderView browser tests. This allows
RenderFrameImpl::OnNavigate to be private again, and RenderViewImplTests is no
longer a friend of RenderFrameImpl.

BUG=475027
Committed: https://crrev.com/98a9dee008d6a7a295f41dca6228fd31ea7595d4
Cr-Commit-Position: refs/heads/master@{#335930}

[clamy, 2015-06-24 13:39:16]

clamy@chromium.org changed reviewers:
+ carlosk@chromium.org, fdegans@chromium.org, nasko@chromium.org

[clamy, 2015-06-24 13:39:43]

@nasko: PTAL
@carlosk, fdegans: FYI

[nasko, 2015-06-24 14:18:02]

LGTM with nits.

https://codereview.chromium.org/1206753003/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.h (right):

https://codereview.chromium.org/1206753003/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.h:618: 
nit: No need for extra empty line here, since this is a list of IPC handlers.

https://codereview.chromium.org/1206753003/diff/1/content/test/test_render_fr...
File content/test/test_render_frame.cc (right):

https://codereview.chromium.org/1206753003/diff/1/content/test/test_render_fr...
content/test/test_render_frame.cc:67:
TestRenderFrame::TestRenderFrame(RenderViewImpl* render_view, int32 routing_id)
Let's move the constructor above the destructor. It is correct that we keep
method ordering matching the header, but this is forced due to the private
declaration of the constructor. Moving it closer to the destructor makes for
easier reading/browsing of the code.

[clamy, 2015-06-24 14:51:03]

Thanks!

https://codereview.chromium.org/1206753003/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.h (right):

https://codereview.chromium.org/1206753003/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.h:618: 
On 2015/06/24 14:18:02, nasko (paris) wrote:
> nit: No need for extra empty line here, since this is a list of IPC handlers.

Done.

https://codereview.chromium.org/1206753003/diff/1/content/test/test_render_fr...
File content/test/test_render_frame.cc (right):

https://codereview.chromium.org/1206753003/diff/1/content/test/test_render_fr...
content/test/test_render_frame.cc:67:
TestRenderFrame::TestRenderFrame(RenderViewImpl* render_view, int32 routing_id)
On 2015/06/24 14:18:02, nasko (paris) wrote:
> Let's move the constructor above the destructor. It is correct that we keep
> method ordering matching the header, but this is forced due to the private
> declaration of the constructor. Moving it closer to the destructor makes for
> easier reading/browsing of the code.

Done.

[clamy, 2015-06-24 14:51:09]

The CQ bit was checked by clamy@chromium.org

[clamy, 2015-06-24 14:51:09]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/1206753003/#ps20001
(title: "Addressed Nasko's comments")

[commit-bot: I haz the power, 2015-06-24 14:51:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1206753003/20001

[commit-bot: I haz the power, 2015-06-24 16:09:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-24 16:10:16]

Patchset 2 (id:??) landed as
https://crrev.com/98a9dee008d6a7a295f41dca6228fd31ea7595d4
Cr-Commit-Position: refs/heads/master@{#335930}