Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 1206743004: DevTools: Disable network filmstrip if experiment is off (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 310 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 var toggled = this._networkLogShowOverviewSetting.get(); 321 var toggled = this._networkLogShowOverviewSetting.get();
322 if (toggled) 322 if (toggled)
323 this._overviewPane.show(this._searchableView.element, this._splitWid get.element); 323 this._overviewPane.show(this._searchableView.element, this._splitWid get.element);
324 else 324 else
325 this._overviewPane.detach(); 325 this._overviewPane.detach();
326 this.doResize(); 326 this.doResize();
327 }, 327 },
328 328
329 _toggleRecordFilmStrip: function() 329 _toggleRecordFilmStrip: function()
330 { 330 {
331 var toggled = this._networkRecordFilmStripSetting.get(); 331 var toggled = Runtime.experiments.isEnabled("filmStripInNetworkAndTimeli ne") && this._networkRecordFilmStripSetting.get();
332 if (toggled && !this._filmStripRecorder) { 332 if (toggled && !this._filmStripRecorder) {
333 this._filmStripView = new WebInspector.FilmStripView(); 333 this._filmStripView = new WebInspector.FilmStripView();
334 this._filmStripView.setMode(WebInspector.FilmStripView.Modes.FrameBa sed); 334 this._filmStripView.setMode(WebInspector.FilmStripView.Modes.FrameBa sed);
335 this._filmStripView.element.classList.add("network-film-strip"); 335 this._filmStripView.element.classList.add("network-film-strip");
336 this._filmStripRecorder = new WebInspector.NetworkPanel.FilmStripRec order(this._filmStripView); 336 this._filmStripRecorder = new WebInspector.NetworkPanel.FilmStripRec order(this._filmStripView);
337 this._filmStripView.show(this._searchableView.element, this._searcha bleView.element.firstElementChild); 337 this._filmStripView.show(this._searchableView.element, this._searcha bleView.element.firstElementChild);
338 this._filmStripView.addEventListener(WebInspector.FilmStripView.Even ts.FrameSelected, this._onFilmFrameSelected, this); 338 this._filmStripView.addEventListener(WebInspector.FilmStripView.Even ts.FrameSelected, this._onFilmFrameSelected, this);
339 this._filmStripView.addEventListener(WebInspector.FilmStripView.Even ts.FrameEnter, this._onFilmFrameEnter, this); 339 this._filmStripView.addEventListener(WebInspector.FilmStripView.Even ts.FrameEnter, this._onFilmFrameEnter, this);
340 this._filmStripView.addEventListener(WebInspector.FilmStripView.Even ts.FrameExit, this._onFilmFrameExit, this); 340 this._filmStripView.addEventListener(WebInspector.FilmStripView.Even ts.FrameExit, this._onFilmFrameExit, this);
341 } 341 }
(...skipping 445 matching lines...) Expand 10 before | Expand all | Expand 10 after
787 { 787 {
788 if (!this._target) 788 if (!this._target)
789 return; 789 return;
790 790
791 this._target.tracingManager.stop(); 791 this._target.tracingManager.stop();
792 this._target = null; 792 this._target = null;
793 this._callback = callback; 793 this._callback = callback;
794 this._filmStripView.setFetching(); 794 this._filmStripView.setFetching();
795 } 795 }
796 } 796 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698