ChromeOs Power Emulation Impl

chromeos/dbus/fake_power_manager_client_unittest.cc

Index: chromeos/dbus/fake_power_manager_client_unittest.cc
diff --git a/chromeos/dbus/fake_power_manager_client_unittest.cc b/chromeos/dbus/fake_power_manager_client_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..55ee8f10778c1524a0d08601383b75ef1956474f
--- /dev/null
+++ b/chromeos/dbus/fake_power_manager_client_unittest.cc
@@ -0,0 +1,145 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromeos/dbus/fake_power_manager_client.h"
+
+#include "base/basictypes.h"
+#include "base/macros.h"
+#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace chromeos {
+namespace {
+
+const double kDefaultBatteryPercent = 85;
+const double kDefaultBatteryPercentChanged = 70;

[oshima, 2015/07/15 21:46:23]

I think following name would be better

kInitialBatteryPercent
kUpdatedBatteryPercent

[Daniel Erat, 2015/07/15 22:02:39]

agreed

[mozartalouis, 2015/07/15 22:10:30]

Done.

+
+class TestObserver : public PowerManagerClient::Observer {
+ public:
+  TestObserver() : num_power_changed_(0) {}
+  ~TestObserver() override {}
+
+  const power_manager::PowerSupplyProperties& props() const { return props_; }
+  int num_power_changed() const { return num_power_changed_; }
+
+  void ClearProps() { props_.Clear(); }
+
+  void PowerChanged(
+      const power_manager::PowerSupplyProperties& proto) override {
+    props_ = proto;
+    ++num_power_changed_;
+  }
+
+ private:
+  int num_power_changed_;
+  power_manager::PowerSupplyProperties props_;
+
+  DISALLOW_COPY_AND_ASSIGN(TestObserver);
+};
+
+void SetTestProperties(power_manager::PowerSupplyProperties* props) {
+  props->set_battery_percent(kDefaultBatteryPercent);
+  props->set_is_calculating_battery_time(true);
+  props->set_battery_state(
+      power_manager::PowerSupplyProperties_BatteryState_DISCHARGING);
+  props->set_external_power(
+      power_manager::PowerSupplyProperties_ExternalPower_USB);
+}
+
+}  // namespace
+
+TEST(FakePowerManagerClientTest, UpdatePowerPropertiesTest) {
+  // Checking to verify when UpdatePowerProperties is called,
+  // |props_| values are updated.
+  FakePowerManagerClient client;
+  power_manager::PowerSupplyProperties props;
+
+  SetTestProperties(&props);
+  client.UpdatePowerProperties(props);
+
+  EXPECT_EQ(kDefaultBatteryPercent, client.props().battery_percent());
+  EXPECT_TRUE(client.props().is_calculating_battery_time());
+  EXPECT_EQ(power_manager::PowerSupplyProperties_BatteryState_DISCHARGING,

[Daniel Erat, 2015/07/15 22:02:39]

make this be a constant at the top of the file too

[mozartalouis, 2015/07/15 22:29:20]

Done.

+            client.props().battery_state());
+  EXPECT_EQ(power_manager::PowerSupplyProperties_ExternalPower_USB,

[Daniel Erat, 2015/07/15 22:02:39]

and this

[mozartalouis, 2015/07/15 22:29:20]

Done.

+            client.props().external_power());
+
+  // Test if when the values are changed, the correct data is set in the
+  // FakePowerManagerClient.
+  props = client.props();
+  props.set_battery_percent(kDefaultBatteryPercentChanged);
+  client.UpdatePowerProperties(props);
+
+  EXPECT_EQ(kDefaultBatteryPercentChanged, client.props().battery_percent());
+  EXPECT_TRUE(client.props().is_calculating_battery_time());
+  EXPECT_EQ(power_manager::PowerSupplyProperties_BatteryState_DISCHARGING,
+            client.props().battery_state());
+  EXPECT_EQ(power_manager::PowerSupplyProperties_ExternalPower_USB,
+            client.props().external_power());
+};
+
+TEST(FakePowerManagerClientTest, NotifyObserversTest) {
+  FakePowerManagerClient client;
+  TestObserver test_observer;
+
+  // Test adding observer.
+  client.AddObserver(&test_observer);
+  EXPECT_TRUE(client.HasObserver(&test_observer));
+
+  // Test if NotifyObservers() sends the correct values to |observer|.
+  // Check number of times NotifyObservers() is called.
+  power_manager::PowerSupplyProperties props;
+  SetTestProperties(&props);
+  client.UpdatePowerProperties(props);
+
+  EXPECT_EQ(kDefaultBatteryPercent, test_observer.props().battery_percent());
+  EXPECT_TRUE(test_observer.props().is_calculating_battery_time());
+  EXPECT_EQ(power_manager::PowerSupplyProperties_BatteryState_DISCHARGING,
+            test_observer.props().battery_state());
+  EXPECT_EQ(power_manager::PowerSupplyProperties_ExternalPower_USB,
+            test_observer.props().external_power());
+  EXPECT_EQ(1, test_observer.num_power_changed());
+
+  // Test if RequestStatusUpdate() will propagate the data to the observer.
+  // Check number of times NotifyObservers is called.
+  // RequestStatusUpdate posts to the current message loop. This is
+  // necessary because we want to make sure that NotifyObservers() is
+  // called as a result of RequestStatusUpdate().
+  base::MessageLoopForUI message_loop;
+  test_observer.ClearProps();
+  client.RequestStatusUpdate();
+  base::RunLoop().RunUntilIdle();

[Daniel Erat, 2015/07/15 22:02:39]

thanks for the explanation. running the message loop here sounds correct, since
the fake's implementation of RequestStatusUpdate() is trying to mimic what the
real implementation does.

[mozartalouis, 2015/07/15 22:10:30]

Acknowledged.

+
+  EXPECT_EQ(kDefaultBatteryPercent, test_observer.props().battery_percent());
+  EXPECT_TRUE(test_observer.props().is_calculating_battery_time());
+  EXPECT_EQ(power_manager::PowerSupplyProperties_BatteryState_DISCHARGING,
+            test_observer.props().battery_state());
+  EXPECT_EQ(power_manager::PowerSupplyProperties_ExternalPower_USB,
+            test_observer.props().external_power());
+  EXPECT_EQ(2, test_observer.num_power_changed());
+
+  // Check when values are changed, the correct values are propagated to the
+  // observer
+  props = client.props();
+  props.set_battery_percent(kDefaultBatteryPercentChanged);
+  props.set_external_power(
+      power_manager::PowerSupplyProperties_ExternalPower_AC);
+  client.UpdatePowerProperties(props);
+
+  EXPECT_EQ(kDefaultBatteryPercentChanged,
+            test_observer.props().battery_percent());
+  EXPECT_TRUE(test_observer.props().is_calculating_battery_time());
+  EXPECT_EQ(power_manager::PowerSupplyProperties_BatteryState_DISCHARGING,
+            test_observer.props().battery_state());
+  EXPECT_EQ(power_manager::PowerSupplyProperties_ExternalPower_AC,
+            test_observer.props().external_power());
+  EXPECT_EQ(3, test_observer.num_power_changed());
+
+  // Test removing observer.
+  client.RemoveObserver(&test_observer);
+  EXPECT_FALSE(client.HasObserver(&test_observer));
+};
+
+}  // namespace chromeos