ChromeOs Power Emulation Impl

chromeos/dbus/fake_power_manager_client.h

Index: chromeos/dbus/fake_power_manager_client.h
diff --git a/chromeos/dbus/fake_power_manager_client.h b/chromeos/dbus/fake_power_manager_client.h
index d6cd0429f975b899ec2a64fc8f8158dce391a83d..b083452d5ed48cb4ee065c673186d7c3e34ecd5b 100644
--- a/chromeos/dbus/fake_power_manager_client.h
+++ b/chromeos/dbus/fake_power_manager_client.h
@@ -7,10 +7,9 @@
 
 #include <string>
 
-#include "base/basictypes.h"
-#include "base/macros.h"
 #include "base/observer_list.h"
 #include "chromeos/dbus/power_manager/policy.pb.h"
+#include "chromeos/dbus/power_manager/power_supply_properties.pb.h"
 #include "chromeos/dbus/power_manager/suspend.pb.h"
 #include "chromeos/dbus/power_manager_client.h"
 
@@ -67,16 +66,32 @@ class FakePowerManagerClient : public PowerManagerClient {
   // Notifies observers that the power button has been pressed or released.
   void SendPowerButtonEvent(bool down, const base::TimeTicks& timestamp);
 
+  // Updates the PowerSupplyProperties and NotifyObservers of its changes.

[Daniel Erat, 2015/07/06 14:28:14]

"NotifyObservers" -> "notifies observers"

[mozartalouis, 2015/07/06 20:49:42]

Done.

+  void UpdatePowerProperties(
+      int battery_percent,
+      bool is_calculating_battery_time,
+      power_manager::PowerSupplyProperties::BatteryState battery_state,
+      power_manager::PowerSupplyProperties::ExternalPower external_power);
+
+  const power_manager::PowerSupplyProperties& props() { return props_; }

[Daniel Erat, 2015/07/06 14:28:14]

please move props() up to where all the other accessors are defined (policy(),
is_projecting(), etc.)

[mozartalouis, 2015/07/06 20:49:42]

Done.

+
  private:
   // Callback that will be run by asynchronous suspend delays to report
   // readiness.
   void HandleSuspendReadiness();
 
+  // Tells TrayPower to update its contents to the Updated

[Daniel Erat, 2015/07/06 14:28:14]

"Updated" -> "updated"

this comment also shouldn't refer to TrayPower, since this class doesn't know
anything about it. please just use something like:

  // Notifies |observers_| that |props_| has been updated.

[mozartalouis, 2015/07/06 20:49:42]

Done.

+  // PowerSupplyProperties.
+  void NotifyObservers();
+
   base::ObserverList<Observer> observers_;
 
   // Last policy passed to SetPolicy().
   power_manager::PowerManagementPolicy policy_;
 
+  // The power properties set for for the UI.

[Daniel Erat, 2015/07/06 14:28:14]

this class doesn't know anything about the UI. how about:

  // Power status received from the power manager.

[mozartalouis, 2015/07/06 20:49:42]

Done.

+  power_manager::PowerSupplyProperties props_;
+
   // Number of times that various methods have been called.
   int num_request_restart_calls_;
   int num_request_shutdown_calls_;