ChromeOs Power Emulation Impl

chromeos/dbus/fake_power_manager_client_unittest.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromeos/dbus/fake_power_manager_client.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace chromeos {
+
+TEST(FakePowerManagerClientTest, UpdatePowerPropertiesTest) {
+  FakePowerManagerClient* client = new FakePowerManagerClient();

[Daniel Erat, 2015/06/30 22:13:31]

you're leaking memory here. why don't you just allocate this on the stack?

[mozartalouis, 2015/07/01 00:43:28]

Done.

+
+  ASSERT_TRUE(client != NULL);

[Daniel Erat, 2015/06/30 22:13:31]

you don't need to test the output of the 'new' operator.

[mozartalouis, 2015/07/01 00:43:28]

Done.

+
+  client->UpdatePowerProperties(
+      80, true, power_manager::PowerSupplyProperties_BatteryState_CHARGING,
+      power_manager::PowerSupplyProperties_ExternalPower_USB);
+
+  EXPECT_EQ(80, client->GetPowerSupplyProperties().battery_percent());
+
+  EXPECT_TRUE(client->GetPowerSupplyProperties().is_calculating_battery_time());
+
+  EXPECT_EQ(power_manager::PowerSupplyProperties_BatteryState_CHARGING,

[Daniel Erat, 2015/06/30 22:13:31]

please test more cases, e.g. _FULL. make sure you add a test that would've
caught the bug that i just pointed out.

[mozartalouis, 2015/07/01 00:43:28]

Done.

+            client->GetPowerSupplyProperties().battery_state());
+
+  EXPECT_EQ(power_manager::PowerSupplyProperties_ExternalPower_USB,
+            client->GetPowerSupplyProperties().external_power());
+}
+
+}  // namespace chromeos