Function Layout, Global Variable Layout and Pooled Constants Layout Reordering

tests_lit/llvm2ice_tests/reorder-global-variables.ll

Index: tests_lit/llvm2ice_tests/reorder-global-variables.ll
diff --git a/tests_lit/llvm2ice_tests/reorder-global-variables.ll b/tests_lit/llvm2ice_tests/reorder-global-variables.ll
new file mode 100644
index 0000000000000000000000000000000000000000..2279c9d2ef065ef8d9f04c29b248a52fa139ef1c
--- /dev/null
+++ b/tests_lit/llvm2ice_tests/reorder-global-variables.ll
@@ -0,0 +1,162 @@
+; Test of global variable reordering.
+
+; REQUIRES: allow_dump
+
+; RUN: %if --need=target_X8632 --command %p2i --filetype=asm --target x8632 \
+; RUN:     -i %s --args -sz-seed=1 -O2 -reorder-global-variables \
+; RUN:     | %if --need=target_X8632 --command FileCheck %s \
+; RUN:     --check-prefix=X8632ASM
+
+; RUN: %if --need=target_X8632 --command %p2i --filetype=obj --target x8632 \
+; RUN:     -i %s --disassemble --dis-flags=-rD \
+; RUN:     --args -sz-seed=1 -O2 -reorder-global-variables \
+; RUN:     | %if --need=target_X8632 --command FileCheck %s \
+; RUN:     --check-prefix=X8632OBJ
+
+; RUN: %if --need=target_ARM32 --command %p2i --filetype=asm --target arm32 \
+; RUN:     -i %s --args -sz-seed=1 -O2 -reorder-global-variables \
+; RUN:     --skip-unimplemented \
+; RUN:     | %if --need=target_ARM32 --command FileCheck %s \
+; RUN:     --check-prefix=ARM32ASM
+
+; IAS is not implemented yet.
+; RUN: %if --need=target_ARM32 --command %p2i --filetype=asm --target arm32 \
+; RUN:     -i %s --assemble --disassemble --dis-flags=-rD \
+; RUN:     --args -sz-seed=1 -O2 -reorder-global-variables \
+; RUN:     --skip-unimplemented \
+; RUN:     | %if --need=target_ARM32 --command FileCheck %s \
+; RUN:     --check-prefix=ARM32OBJ
+
+; RUN: %if --need=target_X8632 --command %p2i --filetype=asm --target x8632 \
+; RUN:     -i %s --args -sz-seed=1 -Om1 -reorder-global-variables \
+; RUN:     | %if --need=target_X8632 --command FileCheck %s \
+; RUN:     --check-prefix=X8632ASM
+
+; RUN: %if --need=target_X8632 --command %p2i --filetype=obj --target x8632 \
+; RUN:     -i %s --disassemble --dis-flags=-rD \
+; RUN:     --args -Om1 -sz-seed=1 -reorder-global-variables \
+; RUN:     | %if --need=target_X8632 --command  FileCheck %s \
+; RUN:     --check-prefix=X8632OBJ
+
+; RUN: %if --need=target_ARM32 --command %p2i --filetype=asm --target arm32 \
+; RUN:     -i %s --args -sz-seed=1 -Om1 -reorder-global-variables \
+; RUN:     --skip-unimplemented \
+; RUN:     | %if --need=target_ARM32 --command FileCheck %s \
+; RUN:     --check-prefix=ARM32ASM
+
+; IAS is not implemented yet.
+; RUN: %if --need=target_ARM32 --command %p2i --filetype=asm --target arm32 \
+; RUN:     -i %s --assemble --disassemble --dis-flags=-rD \
+; RUN:     --args -sz-seed=1 -Om1 -reorder-global-variables \
+; RUN:     --skip-unimplemented \
+; RUN:     | %if --need=target_ARM32 --command FileCheck %s \
+; RUN:     --check-prefix=ARM32OBJ
+
+
+define internal i32 @main(i32 %argc, i32 %argv) {

[Jim Stichnoth, 2015/06/25 13:20:59]

I think this test could be simplified by removing all the functions, leaving
just the global declarations/definitions.

Also, you could probably remove the @__* globals, as they are basically just
left over from some automatic C-to-bitcode conversion script.

If you remove @__*, you can probably combine the ASM and OBJ filecheck prefixes
into a single set of check lines.

[qining, 2015/06/25 21:10:10]

Done.

+entry:
+  %expanded1 = ptrtoint [4 x i8]* @PrimitiveInit to i32
+  call void @use(i32 %expanded1)
+  %expanded3 = ptrtoint [4 x i8]* @PrimitiveInitConst to i32
+  call void @use(i32 %expanded3)
+  %expanded5 = ptrtoint [4 x i8]* @PrimitiveInitStatic to i32
+  call void @use(i32 %expanded5)
+  %expanded7 = ptrtoint [4 x i8]* @PrimitiveUninit to i32
+  call void @use(i32 %expanded7)
+  %expanded9 = ptrtoint [20 x i8]* @ArrayInit to i32
+  call void @use(i32 %expanded9)
+  %expanded11 = ptrtoint [40 x i8]* @ArrayInitPartial to i32
+  call void @use(i32 %expanded11)
+  %expanded13 = ptrtoint [20 x i8]* @ArrayUninit to i32
+  call void @use(i32 %expanded13)
+  ret i32 0
+}
+declare void @use(i32)
+
+define internal i32 @nacl_tp_tdb_offset(i32 %__0) {
+entry:
+  ret i32 0
+}
+
+define internal i32 @nacl_tp_tls_offset(i32 %size) {
+entry:
+  %result = sub i32 0, %size
+  ret i32 %result
+}
+
+
+@PrimitiveInit = internal global [4 x i8] c"\1B\00\00\00", align 4
+
+@PrimitiveInitConst = internal constant [4 x i8] c"\0D\00\00\00", align 4
+
+@ArrayInit = internal global [20 x i8] c"\0A\00\00\00\14\00\00\00\1E\00\00\00(\00\00\002\00\00\00", align 4
+
+@ArrayInitPartial = internal global [40 x i8] c"<\00\00\00F\00\00\00P\00\00\00Z\00\00\00d\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00", align 4
+
+@PrimitiveInitStatic = internal global [4 x i8] zeroinitializer, align 4
+
+@PrimitiveUninit = internal global [4 x i8] zeroinitializer, align 4
+
+@ArrayUninit = internal global [20 x i8] zeroinitializer, align 4
+
+@ArrayUninitConstDouble = internal constant [200 x i8] zeroinitializer, align 8
+
+@ArrayUninitConstInt = internal constant [20 x i8] zeroinitializer, align 4
+
+@__init_array_start = internal constant [0 x i8] zeroinitializer, align 4
+@__fini_array_start = internal constant [0 x i8] zeroinitializer, align 4
+@__tls_template_start = internal constant [0 x i8] zeroinitializer, align 8
+@__tls_template_alignment = internal constant [4 x i8] c"\01\00\00\00", align 4
+
+; Make sure the shuffled order is correct.
+
+; X8632ASM-LABEL: PrimitiveUninit
+; X8632ASM-LABEL: __init_array_start
+; X8632ASM-LABEL: ArrayUninitConstDouble
+; X8632ASM-LABEL: __tls_template_alignment
+; X8632ASM-LABEL: ArrayInitPartial
+; X8632ASM-LABEL: ArrayUninit
+; X8632ASM-LABEL: ArrayInit
+; X8632ASM-LABEL: __fini_array_start
+; X8632ASM-LABEL: PrimitiveInitStatic
+; X8632ASM-LABEL: ArrayUninitConstInt
+; X8632ASM-LABEL: PrimitiveInit
+; X8632ASM-LABEL: PrimitiveInitConst
+; X8632ASM-LABEL: __tls_template_start
+
+; X8632OBJ-LABEL: ArrayInitPartial
+; X8632OBJ-LABEL: ArrayInit
+; X8632OBJ-LABEL: PrimitiveInit
+; X8632OBJ-LABEL: PrimitiveUninit
+; X8632OBJ-LABEL: ArrayUninit
+; X8632OBJ-LABEL: PrimitiveInitStatic
+; X8632OBJ-LABEL: ArrayUninitConstDouble
+; X8632OBJ-LABEL: __tls_template_alignment
+; X8632OBJ-LABEL: ArrayUninitConstInt
+; X8632OBJ-LABEL: PrimitiveInitConst
+
+; ARM32ASM-LABEL: PrimitiveUninit
+; ARM32ASM-LABEL: __init_array_start
+; ARM32ASM-LABEL: ArrayUninitConstDouble
+; ARM32ASM-LABEL: __tls_template_alignment
+; ARM32ASM-LABEL: ArrayInitPartial
+; ARM32ASM-LABEL: ArrayUninit
+; ARM32ASM-LABEL: ArrayInit
+; ARM32ASM-LABEL: __fini_array_start
+; ARM32ASM-LABEL: PrimitiveInitStatic
+; ARM32ASM-LABEL: ArrayUninitConstInt
+; ARM32ASM-LABEL: PrimitiveInit
+; ARM32ASM-LABEL: PrimitiveInitConst
+; ARM32ASM-LABEL: __tls_template_start
+
+; ARM32OBJ-LABEL: ArrayInitPartial
+; ARM32OBJ-LABEL: ArrayInit
+; ARM32OBJ-LABEL: PrimitiveInit
+; ARM32OBJ-LABEL: PrimitiveUninit
+; ARM32OBJ-LABEL: ArrayUninit
+; ARM32OBJ-LABEL: PrimitiveInitStatic
+; ARM32OBJ-LABEL: ArrayUninitConstDouble
+; ARM32OBJ-LABEL: __tls_template_alignment
+; ARM32OBJ-LABEL: ArrayUninitConstInt
+; ARM32OBJ-LABEL: PrimitiveInitConst
+

[Jim Stichnoth, 2015/06/25 13:20:59]

trailing blank line

[qining, 2015/06/25 21:10:10]

Done.